fix(string-store)!: use only valid unicode characters to encode #935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranet
requested changes
Nov 21, 2025
kyranet
previously approved these changes
Nov 23, 2025
kyranet
approved these changes
Nov 24, 2025
Member
|
@sapphiredev pack this |
|
Hey @kyranet, I've released this to NPM. You can install it for testing like so: npm install @sapphire/fetch@pr-935 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes fix the string-store library by only using specific ranges of valid Unicode characters to encode. The ranges were chosen pretty much arbitrarily, just based on the biggest ranges that add together to 2^16.
This is a breaking change for existing encoded strings, as the characters used to encode are now different.
I removed some lines from the test cases that checked string equality, as right now these are just 'random' codepoints, not 1:1 with the int value.