[BUG] Salt installer 3006+ doesn't remove older installs

[twangboy]

Description
The current installer only looks for the Salt Service Manager (ssm.exe) in the root of the install directory. Older versions of Salt have installed the service manager in different locations:

2016.11 - 2017.7 : C:\salt\bin\nssm.exe
2018.3 - 3003 : C:\salt\bin\ssm.exe
3004 - 3005 : C:\Program Files\Salt Project\Salt\bin\ssm.exe
3006 - 3007+ : C:\Program Files\Salt Project\Salt\ssm.exe

When performing an upgrade, the current installer only looks in the last location (3006 - 3007) for the ssm.exe. If it finds it, it uninstalls the salt service, then uninstalls that version of salt, and the installation continues. This is good.

When the existing installation is older than 3006, the current installer looks for ssm.exe, doesn't find it, and just starts removing files, much of which will fail because the salt-minion service is still running. This is bad.

Setup
Install 3005.5. Then install 3006.10. The minion upgrade will leave behind a bin directory that shouldn't exist.

Please be as specific as possible and give set-up details.

• on-prem machine
• VM (Virtualbox, KVM, etc. please specify)
• VM running on a cloud service, please be explicit and add details
• container (Kubernetes, Docker, containerd, etc. please specify)
• or a combination, please be explicit
• jails if it is FreeBSD
• classic packaging
• onedir packaging
• used bootstrap to install

Versions Report

salt --versions-report

(Provided by running salt --versions-report. Please also mention any differences in master/minion versions.)

3006.10+