[FEATURE REQUEST] The premise of a large number of servers takes too long to delete servers.

[WMMMD]

Background

• Single-master architecture
• 7w minions (due to business architecture, no other high availability architecture is used)

Problems
When submitting a minion for deletion, it takes 98s to delete a minion, and we found that the problem lies in the check_minion_cache called under the delete_key function in key.py, where if minion not in minions and minion not in If minion not in minions and minion not in minions take a particularly long time, the query problem should be a list traversal problem.

Solution:
Change list to set

Before

if minion not in minions and minion not in preserve_minions:

After modification

minions_set = set(minions)
preserve_minions_set = set(preserve_minions)
if minion not in minions_set and minion not in preserve_minions_set:

In our usage scenario, deleting a server was reduced from 98 seconds to 0.5 seconds, and the query deletion actually took effect.

[welcome]

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

• Salt’s Contributor Guide
• Join our Community Discord
• Salt Project YouTube channel
• Community Wiki

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at [email protected]. We’re glad you’ve joined our community and look forward to doing awesome things with you!