Skip to content

[DOCS] option "user" is misnamed. It should be "owner" #67911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dnessett opened this issue Mar 22, 2025 · 3 comments
Open

[DOCS] option "user" is misnamed. It should be "owner" #67911

dnessett opened this issue Mar 22, 2025 · 3 comments
Labels
Documentation Relates to Salt documentation

Comments

@dnessett
Copy link

Description
In the documentation for salt.modules.file.find, the option "user" is misnamed. It should be "owner".

Suggested Fix
Change the documentation by replacing "user" with "owner"

Type of documentation
Salt Modules

Location or format of documentation
salt.modules.file.find

Additional context
N/A

@dnessett dnessett added Documentation Relates to Salt documentation needs-triage labels Mar 22, 2025
@dwoz dwoz changed the title [DOCS] [DOCS] option "user" is misnamed. It should be "owner" Mar 24, 2025
@dwoz dwoz removed the needs-triage label Mar 24, 2025
@dwoz
Copy link
Contributor

dwoz commented Mar 24, 2025

@dnessett Are you able to create a PR against 3006.x for this please?

@dnessett
Copy link
Author

I thought I did. Here is the record of my git commands:

1736 git clone https://github.com/dnessett/salt
1739 git remote add upstream https://github.com/saltstack/salt.git
1740 git checkout -b 3006.x origin/3006.x
1741 git fetch upstream
1742 git checkout -b bugfix-67911 3006.x
1743 git branch
1750 git status
1751 git add file.py
1753 git status
1754 git commit
1756 git diff HEAD^ HEAD
1757 history | grep 'git push'
1758 git push origin bugfix-67911

I later added the changelog entry

1768 git status
1769 git add changelog/67911.fixed.md
1770 git commit
1771 git status
1772 git log
1774 git push origin bugfix-67911

I originally created the PR before adding the changelog commit, but after committing it, the PR seemed to accept both commits to bugfix-67911.

I don't know how to check what branch is the base of bugfix-67911 and I couldn't find anything by googling. Let me know what I need to do and I will try and fix the problem.

@dnessett
Copy link
Author

I just realized I perhaps misunderstood you. I have already created the PR: #67912

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Relates to Salt documentation
Projects
None yet
Development

No branches or pull requests

2 participants