Skip to content

[Sphinx] [Automation] Make sure Issue -> PR conversion of hyperlinks is correct #221

@felix91gr

Description

@felix91gr

When working on #180, I found a bug in the conversion of hyperlinks from Markdown to RST.

Input

This is the original paragraph, as written in the CG Issue:

In particular, the user should only perform left shifts via the [`checked_shl`](https://doc.rust-lang.org/core/index.html?search=%22checked_shl%22) function and right shifts via the [`checked_shr`](https://doc.rust-lang.org/core/index.html?search=%22checked_shr%22) function. Both of these functions exist in [`core`](https://doc.rust-lang.org/core/index.html).

, which when reduced to a single link looks like this:

[`checked_shl`](https://doc.rust-lang.org/core/index.html?search=%22checked_shl%22)

Output

Current (incorrect)

This is what the automation currently produces:

`\ ``checked_shl`` <https://doc.rust-lang.org/core/index.html?search=%22checked_shl%22>`_ 

Expected (correct)

This is, however, what it should produce:

`checked_shl <https://doc.rust-lang.org/core/index.html?search=%22checked_shl%22>`_

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingcontributor experienceRelated to making contributions easierhelp wantedExtra attention is needed

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions