Refactor the `clippy_lints/src/strings.rs` file

[samueltardieu]

Description

With the exception of string_add, string_add_assign and string_slice (which share an implementation), all lints in strings.rs could be moved into the methods module in order to share the tree traversal with other method call and function call lints.

[VimalanS369]

Hey! @samueltardieu I don't see a strings.src file in clippy_utils/src and I am contributing for the first time...could you help me out with the issue?

[samueltardieu]

Yeah, this is a typo, I'll fix this: clippy_lints/src/strings.rs. Welcome!

[profetia]

Good suggestion. Looks like several methods on string is already in the methods module.

[profetia]

@rustbot claim

[samueltardieu]

Didn't @VimalanS369 plan to do it as their first issue? (they might not have been aware of the rustbot command to claim it, just checking)

[profetia]

I see, I will release it then.

[profetia]

@rustbot release-assignment

[VimalanS369]

@profetia No. Go ahead. You can do it.

[paolo9921]

Hey, I'm new to contributing (this would be my first one). I don't know how things and precedence work. @profetia, do you want to do this issue, or can I proceed?

[profetia]

Hey, I'm new to contributing (this would be my first one). I don't know how things and precedence work. @profetia, do you want to do this issue, or can I proceed?

Just go ahead and welcome to the project!