Support tuple in mir fn body #205
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcnr
reviewed
Oct 29, 2025
| // FIXME: we only support const in value expression of tuple for now, we can add support | ||
| // more in future. | ||
| let Constant(_) = value_expression else { | ||
| bail!("Only Constant is supported in ValueExpression::Struct for now.") |
Contributor
There was a problem hiding this comment.
Suggested change
| bail!("Only Constant is supported in ValueExpression::Struct for now.") | |
| bail!("Only Constant is supported in ValueExpression::Tuple for now.") |
tiif
commented
Nov 7, 2025
Comment on lines
-288
to
-305
| let Some(adt_id) = ty.get_adt_id() else { | ||
| bail!("The local used for field projection is not adt.") | ||
| }; | ||
|
|
||
| let ( | ||
| _, | ||
| AdtDeclBoundData { | ||
| where_clause: _, | ||
| variants, | ||
| }, | ||
| ) = self.decls.adt_decl(&adt_id).binder.open(); | ||
| let AdtDeclVariant { name, fields } = variants.last().unwrap(); | ||
|
|
||
| if *name != VariantId::for_struct() { | ||
| bail!("The local used for field projection must be struct.") | ||
| if !ty.is_tuple() && !ty.is_adt() { | ||
| bail!("The local used for field projection must be ADT or Tuple") | ||
| } | ||
|
|
||
| // Check if the index is valid for the tuple. |
Member
Author
There was a problem hiding this comment.
This is wrong, While tuple (i32, u32)'s parameter is [i32, u32],
struct Foo<T> {
value: T
}struct Foo's parameter is T.
But I don't like how we need to go through self.decls to get the struct field information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.