Skip to content

Commit e0b9c25

Browse files
committed
🎨 Address code review from @kou
- Add bundle install - Remove extra comments
1 parent 125e531 commit e0b9c25

File tree

3 files changed

+3
-8
lines changed

3 files changed

+3
-8
lines changed
File renamed without changes.
File renamed without changes.

β€Ž.devcontainer/devcontainer.jsonβ€Ž renamed to β€Ž.devcontainer/2.5/devcontainer.jsonβ€Ž

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,20 +2,15 @@
22
// README at: https://github.com/devcontainers/templates/tree/main/src/ruby
33
{
44
"name": "Ruby 2.5 on Debian",
5-
"image": "ruby:2.5-buster", // Specify the Ruby 2.5 image
6-
"postCreateCommand": "RUBYGEMS_VERSION=3.3.27\ngem install rubygems-update -v ${RUBYGEMS_VERSION} > /dev/null 2>&1\nupdate_rubygems > /dev/null 2>&1\n", // Optional: Run this command after the container is created
5+
"image": "ruby:2.5-buster",
6+
"postCreateCommand": "RUBYGEMS_VERSION=3.3.27\ngem install rubygems-update -v ${RUBYGEMS_VERSION} > /dev/null 2>&1 &&\nupdate_rubygems > /dev/null 2>&1 &&\nbundle install",
77

88
// Features to add to the dev container. More info: https://containers.dev/features.
9+
// Features run during the image build, and thus before the lifecycle hooks in this file, e.g., postCreateCommand
910
"features": {
1011
"./apt-install": {}
1112
},
1213

13-
// Use 'forwardPorts' to make a list of ports inside the container available locally.
14-
// "forwardPorts": [],
15-
16-
// Use 'postCreateCommand' to run commands after the container is created.
17-
// "postCreateCommand": "ruby --version",
18-
1914
// Configure tool-specific properties.
2015
"customizations": {
2116
"jetbrains": {

0 commit comments

Comments
Β (0)