Add routes as a non overridable methods so that memoization works properly. Added a better specs so that a private method is not expected and memoization is really tested.

Author: ericproulx

lib/grape/api.rb

@@ -5,7 +5,7 @@ module Grape
   # should subclass this class in order to build an API.
   class API
     # Class methods that we want to call on the API rather than on the API object
-    NON_OVERRIDABLE = %i[call call! configuration compile! inherited recognize_path].freeze
+    NON_OVERRIDABLE = %i[call call! configuration compile! inherited recognize_path routes].freeze
 
     Helpers = Grape::DSL::Helpers::BaseHelper
 

lib/grape/api/instance.rb

@@ -103,10 +103,6 @@ def recognize_path(path)
 
         protected
 
-        def prepare_routes
-          endpoints.map(&:routes).flatten
-        end
-
         # Execute first the provided block, then each of the
         # block passed in. Allows for simple 'before' setups
         # of settings stack pushes.

lib/grape/dsl/routing.rb

@@ -195,7 +195,7 @@ def namespace(space = nil, options = {}, &block)
 
       # An array of API routes.
       def routes
-        @routes ||= prepare_routes
+        @routes ||= endpoints.map(&:routes).flatten
       end
 
       # Remove all defined routes.

spec/grape/dsl/routing_spec.rb

@@ -274,22 +274,23 @@ def self.route_setting_hash
   end
 
   describe '.routes' do
-    let(:routes) { Object.new }
+    let(:main_app) { Class.new(Grape::API) }
+    let(:first_app) { Class.new(Grape::API) }
+    let(:second_app) { Class.new(Grape::API) }
 
-    it 'returns value received from #prepare_routes' do
-      expect(subject).to receive(:prepare_routes).and_return(routes)
-      expect(subject.routes).to eq routes
+    before do
+      main_app.mount(first_app => '/first_app', second_app => '/second_app')
     end
 
-    context 'when #routes was already called once' do
-      before do
-        allow(subject).to receive(:prepare_routes).and_return(routes)
-        subject.routes
-      end
+    it 'returns flatten endpoints routes' do
+      expect(main_app.endpoints).not_to be_empty
+      expect(main_app.routes).to eq(main_app.endpoints.map(&:routes).flatten)
+    end
 
-      it 'does not call prepare_routes again' do
-        expect(subject).not_to receive(:prepare_routes)
-        expect(subject.routes).to eq routes
+    context 'when #routes was already called once' do
+      it 'memoizes' do
+        object_id = main_app.routes.object_id
+        expect(main_app.routes.object_id).to eq(object_id)
       end
     end
   end