Skip to content

Commit eb7708e

Browse files
jonbinneyjonbinney
committed
Declare speckle filter params writeable
1 parent ed29567 commit eb7708e

20 files changed

+114
-0
lines changed

‎include/laser_filters/speckle_filter.h‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,18 @@ class LaserScanSpeckleFilter : public filters::FilterBase<sensor_msgs::msg::Lase
174174

175175
///////////////////////////////////////////////////////////////
176176
bool configure(){
177+
178+
#ifdef RCLCPP_SUPPORTS_POST_SET_PARAMS_CALLBACK
179+
// Declare parameters as writeable. Otherwise, the first time we call FilterBase::getParam() for each one,
180+
// it will get declared as write only.
181+
rcl_interfaces::msg::ParameterDescriptor desc;
182+
desc.read_only = true;
183+
params_interface_->declare_parameter("filter_type", rclcpp::ParameterType::PARAMETER_INTEGER, desc);
184+
params_interface_->declare_parameter("max_range", rclcpp::ParameterType::PARAMETER_DOUBLE, desc);
185+
params_interface_->declare_parameter("max_range_difference", rclcpp::ParameterType::PARAMETER_DOUBLE, desc);
186+
params_interface_->declare_parameter("filter_window", rclcpp::ParameterType::PARAMETER_INTEGER, desc);
187+
#endif
188+
177189
// get params
178190
if (!filters::FilterBase<sensor_msgs::msg::LaserScan>::getParam(std::string("filter_type"), filter_type))
179191
{

‎install/.colcon_install_layout‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
isolated

‎log/COLCON_IGNORE‎

Whitespace-only changes.

‎log/latest‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
latest_test-result

‎log/latest_test‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
test_2024-08-20_23-21-03

‎log/latest_test-result‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
test-result_2024-08-20_23-21-03

‎log/test-result_2024-08-20_23-21-03/logger_all.log‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
[0.062s] DEBUG:colcon:Command line arguments: ['/usr/bin/colcon', 'test-result', '--all']
2+
[0.063s] DEBUG:colcon:Parsed command line arguments: Namespace(log_base=None, log_level=None, verb_name='test-result', test_result_base='build', all=True, result_files_only=False, verbose=False, delete=False, delete_yes=False, mixin_files=None, mixin=None, verb_parser=<colcon_mixin.mixin.mixin_argument.MixinArgumentDecorator object at 0x750eb0da6750>, verb_extension=<colcon_test_result.verb.test_result.TestResultVerb object at 0x750eb0eb8290>, main=<bound method TestResultVerb.main of <colcon_test_result.verb.test_result.TestResultVerb object at 0x750eb0eb8290>>, mixin_verb=('test-result',))
3+
[0.064s] Level 1:colcon.colcon_test_result.test_result:get_test_results(ctest)
4+
[0.065s] Level 1:colcon.colcon_test_result.test_result:get_test_results(xunit)

‎log/test_2024-08-20_23-21-03/events.log‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
[0.000000] (-) TimerEvent: {}
2+
[0.000491] (laser_filters) JobQueued: {'identifier': 'laser_filters', 'dependencies': OrderedDict({'laser_filters': '/ws/src/src/laser_filters/install/laser_filters'})}
3+
[0.000550] (laser_filters) JobStarted: {'identifier': 'laser_filters'}
4+
[0.015442] (laser_filters) StderrLine: {'line': b'Traceback (most recent call last):\n File "/usr/lib/python3/dist-packages/colcon_core/executor/__init__.py", line 91, in __call__\n rc = await self.task(*args, **kwargs)\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File "/usr/lib/python3/dist-packages/colcon_core/task/__init__.py", line 93, in __call__\n return await task_method(*args, **kwargs)\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File "/usr/lib/python3/dist-packages/colcon_ros/task/ament_cmake/test.py", line 29, in test\n return await extension.test()\n ^^^^^^^^^^^^^^^^^^^^^^\n File "/usr/lib/python3/dist-packages/colcon_cmake/task/cmake/test.py", line 45, in test\n assert os.path.exists(args.build_base), \\\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\nAssertionError: Has this package been built before?\n'}
5+
[0.015812] (laser_filters) JobEnded: {'identifier': 'laser_filters', 'rc': 1}
6+
[0.025687] (-) EventReactorShutdown: {}

‎log/test_2024-08-20_23-21-03/laser_filters/command.log‎

Whitespace-only changes.

‎log/test_2024-08-20_23-21-03/laser_filters/stderr.log‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
Traceback (most recent call last):
2+
File "/usr/lib/python3/dist-packages/colcon_core/executor/__init__.py", line 91, in __call__
3+
rc = await self.task(*args, **kwargs)
4+
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
5+
File "/usr/lib/python3/dist-packages/colcon_core/task/__init__.py", line 93, in __call__
6+
return await task_method(*args, **kwargs)
7+
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
8+
File "/usr/lib/python3/dist-packages/colcon_ros/task/ament_cmake/test.py", line 29, in test
9+
return await extension.test()
10+
^^^^^^^^^^^^^^^^^^^^^^
11+
File "/usr/lib/python3/dist-packages/colcon_cmake/task/cmake/test.py", line 45, in test
12+
assert os.path.exists(args.build_base), \
13+
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
14+
AssertionError: Has this package been built before?

0 commit comments

Comments
 (0)