Skip to content

Commit 94cc4a4

Browse files
committed
Merged main
2 parents d9a0f18 + 826371f commit 94cc4a4

File tree

5 files changed

+11
-7
lines changed

5 files changed

+11
-7
lines changed

.github/workflows/build-docs.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ jobs:
2424
path: ~/.cache
2525
restore-keys: |
2626
mkdocs-material-
27+
- name: Install GDAL
28+
run: sudo apt-get update && sudo apt-get install -y gdal-bin libgdal-dev
2729
- run: cd /tmp && git clone --depth 1 https://github.com/rom-py/rompy-notebooks.git
2830
- run: cp -r /tmp/rompy-notebooks/notebooks docs/
2931
- run: pip install .[docs]

Makefile

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -76,9 +76,6 @@ servedocs: ## serve documentation with MkDocs, watching for changes
7676
apidocs: ## generate API documentation using mkdocstrings
7777
mkdocs build
7878

79-
servedocs: docs ## compile the docs watching for changes
80-
watchmedo shell-command -p '*.rst' -c '$(MAKE) -C docs html' -R -D .
81-
8279
release: dist ## package and upload a release
8380
twine upload dist/*
8481

README.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
1-
---
2-
title: "Relocatable Ocean Modelling in PYthon (rompy)"
3-
---
1+
# "Relocatable Ocean Modelling in PYthon (rompy)"
42

53
[![DOI](https://zenodo.org/badge/DOI/10.5281/zenodo.15093426.svg)](https://doi.org/10.5281/zenodo.15093426)
64
[![GitHub Pages](https://github.com/rom-py/rompy/actions/workflows/sphinx_docs_to_gh_pages.yaml/badge.svg)](https://rom-py.github.io/rompy/)
@@ -15,6 +13,7 @@ title: "Relocatable Ocean Modelling in PYthon (rompy)"
1513
Relocatable Ocean Modelling in PYthon (rompy) is a modular Python library that aims to streamline the setup, configuration, execution, and analysis of coastal ocean models. Rompy combines templated model configuration with powerful xarray-based data handling and pydantic validation, enabling users to efficiently generate model control files and input datasets for a variety of ocean and wave models. The architecture centers on high-level execution control (`ModelRun`) and flexible configuration objects, supporting both persistent scientific model state and runtime backend selection. Rompy provides unified interfaces for grids, data sources, boundary conditions, and spectra, with extensible plugin support for new models and execution environments. Comprehensive documentation, example Jupyter notebooks, and a robust logging/formatting framework make rompy accessible for both research and operational workflows. Current model support includes SWAN and SCHISM, with ongoing development for additional models and cloud/HPC backends.
1614

1715
Key Features:
16+
1817
- Modular architecture with clear separation of configuration and execution logic
1918
- Templated, reproducible model configuration using pydantic and xarray
2019
- Unified interfaces for grids, data, boundaries, and spectra
@@ -27,7 +26,7 @@ rompy is under active development—features, model support, and documentation a
2726

2827
# Documentation
2928

30-
See https://rom-py.github.io/rompy/
29+
See <https://rom-py.github.io/rompy/>
3130

3231
# Code Formatting and Pre-commit Hooks
3332

pyproject.toml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,10 @@ docs = [
101101
notebooks = [
102102
"rompy-notebooks @ git+https://github.com/rom-py/rompy-notebooks.git@package",
103103
]
104+
test = ["pytest", "envyaml", "coverage"]
105+
extra = ["gcsfs", "zarr", "cloudpathlib[s3,gs,azure]"]
106+
dev = ["pytest", "envyaml", "coverage", "ruff", "black"]
107+
docs = ["mkdocs", "mkdocs-material", "mkdocstrings[python]"]
104108

105109
[tool.setuptools.packages.find]
106110
where = ["src"]

src/rompy/core/source.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -191,6 +191,7 @@ class SourceDatamesh(SourceBase):
191191
description="The id of the datasource on Datamesh",
192192
)
193193
token: Optional[str] = Field(
194+
default=None,
194195
description="Datamesh API token, taken from the environment if not provided",
195196
)
196197
kwargs: dict = Field(
@@ -246,6 +247,7 @@ def _open(self, variables: list, geofilter: dict, timefilter: dict) -> xr.Datase
246247
geofilter=geofilter,
247248
timefilter=timefilter,
248249
)
250+
logger.debug(f"Datamesh query: {query}")
249251
return self.connector.query(query)
250252

251253
def open(

0 commit comments

Comments
 (0)