Password with '@' causes a bug

[thenightmail]

If the password has an '@' then the user saves the settings, the password is saved leading up to the first @ and puts the rest of the password into the host url.

[thenightmail]

This is probably the relevent code that needs changing.

stig/stig/client/utils.py

Lines 624 to 681 in 805e2bc

	class URL():
	"""Parse URL as lenient as possible (no validation)"""
	# Pilfered from yurl: https://github.com/homm/yurl
	# This is not validating regexp.
	# It splits url to unambiguous parts according RFC.
	_split_re = re.compile(r'''
	(?:([^:/?#]+):)? # scheme
	(?:// # authority
	(?:([^/?\#@]*)@)? # userinfo
	([^/?\#]*) # host:port
	)?
	([^?\#]*) # path
	\??([^\#]*) # query
	\#?(.*) # fragment
	''', re.VERBOSE | re.DOTALL).match
	@classmethod
	def _parse_url(cls, url):
	# Default to http scheme so 'host:123' is not interpreted as 'host://123/'
	if len(url) > 0 and '://' not in str(url):
	url = 'http://' + str(url)
	groups = cls._split_re(url).groups('')
	# Order: scheme, user+password, host+port, path, query, fragment
	dct = {}
	dct['scheme'] = groups[0] or None
	dct['path'] = groups[3] or None
	dct['query'] = groups[4] or None
	dct['fragment'] = groups[5] or None
	auth = groups[1]
	user, pw = None, None
	if auth:
	# Password in authentication is optional
	if ':' in auth:
	user, pw = auth.split(':')
	else:
	user, pw = auth, None
	dct['user'] = user or None
	dct['password'] = pw or None
	# Split port from host only if it consists of digits.
	host = groups[2]
	port = None
	port_idx = host.rfind(':')
	if port_idx >= 0:
	port_str = host[port_idx + 1:]
	if port_str.isdigit():
	host = host[:port_idx]
	port = int(port_str)
	dct['host'] = host or None
	dct['port'] = port or None
	return dct
	_obj_cache = {}

[thenightmail]

a potential fix is checking if the url string contains multiple '@' symbols and handeling it differently if it does. Not sure if this is the best solution, any thoughts?

[rndusr]

Example URL: ***@***.***@localhost:9091 I suppose splitting at the rightmost "@" to get the username/password combo would solve your issue. But implementing this without unit tests (which are are broken and will probably stay broken) is very tedious. And we still wouldn't know if the username is "username" or "username:http" or "username:http://foo", so there will always be some ambiguity. If you have special characters in your "username:password" combo, using different settings should work: set connect.url http://localhost:9091 set connect.username user:name set connect.password ***@***.***

[rndusr]

Ugh. GitHub can't process simple ASCII text in 2025, apparently. I'm afraid you have to use your imagination to fill in the asterisks, because I can't be arsed to work around shenanigans like that. Sorry. (But not sorry.)