Merge branch 'master' into fields-will-merge-response-type-check

Author: rmosolgo

Diff for: .github/workflows/apidocs.yaml

@@ -21,17 +21,17 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout release tag
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           ref: ${{ env.GITHUB_REF }}
       - name: Checkout GitHub pages branch
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           path: gh-pages
           ref: gh-pages
       - uses: ruby/setup-ruby@v1
         with:
-          ruby-version: '3.0'
+          ruby-version: '3.2'
           bundler-cache: true
       - name: Build API docs
         run: |

Diff for: .github/workflows/ci.yaml

@@ -6,24 +6,32 @@ jobs:
   lint:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
     - uses: ruby/setup-ruby@v1
       with:
-        ruby-version: 2.6
+        ruby-version: 3.4
         bundler-cache: true
     - run: bundle exec rake rubocop
   system_tests:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v3
+    - uses: shogo82148/actions-setup-redis@v1
+      with:
+        redis-version: "7.x"
+    - run: redis-cli ping
+    - uses: actions/checkout@v4
     - uses: ruby/setup-ruby@v1
       with:
-        ruby-version: 2.7.3
+        ruby-version: 3.4
         bundler-cache: true
       env:
-        BUNDLE_GEMFILE: ./spec/dummy/Gemfile
-    - run: bundle exec rails test:system
+        BUNDLE_GEMS__GRAPHQL__PRO: ${{ secrets.BUNDLE_GEMS__GRAPHQL__PRO }}
+        BUNDLE_GEMFILE: gemfiles/rails_master.gemfile
+    - run: bin/rails test:all
       working-directory: ./spec/dummy
+      env:
+        BUNDLE_GEMS__GRAPHQL__PRO: ${{ secrets.BUNDLE_GEMS__GRAPHQL__PRO }}
+        BUNDLE_GEMFILE: ../../gemfiles/rails_master.gemfile
   # Some coverage goals of these tests:
   # - Test once without Rails at all
   # - Test postgres, to make sure that the ActiveRecord
@@ -38,42 +46,65 @@ jobs:
       matrix:
         include:
           - gemfile: Gemfile
-            ruby: 3.1
-          - gemfile: gemfiles/rails_4.2.gemfile
-            ruby: 2.4
-            bundler: "1"
-          - gemfile: gemfiles/rails_5.2.gemfile
-            ruby: 2.7
-          # Rails 6.1 is tested with Postgresql below
+            ruby: 3.4
+          - gemfile: Gemfile
+            ruby: 2.7 # lowest supported version
           - gemfile: gemfiles/rails_7.0.gemfile
             ruby: 3.1
-          - gemfile: gemfiles/rails_master.gemfile
-            ruby: 3.1
           - gemfile: gemfiles/rails_7.0.gemfile
             ruby: 3.2
+          - gemfile: gemfiles/rails_7.1.gemfile
+            ruby: 3.3
           - gemfile: gemfiles/rails_master.gemfile
-            ruby: 3.2
+            ruby: 3.3
+            graphql_reject_numbers_followed_by_names: 1
+            redis: 1
+          - gemfile: gemfiles/rails_master.gemfile
+            ruby: 3.4
+            graphql_reject_numbers_followed_by_names: 1
+            isolation_level_fiber: 1
+            redis: 1
     runs-on: ubuntu-latest
     steps:
     - run: echo BUNDLE_GEMFILE=${{ matrix.gemfile }} > $GITHUB_ENV
-    - uses: actions/checkout@v3
+    - run: echo GRAPHQL_REJECT_NUMBERS_FOLLOWED_BY_NAMES=1 > $GITHUB_ENV
+      if: ${{ !!matrix.graphql_reject_numbers_followed_by_names }}
+    - run: echo ISOLATION_LEVEL_FIBER=1 > $GITHUB_ENV
+      if: ${{ !!matrix.isolation_level_fiber }}
+    - uses: shogo82148/actions-setup-redis@v1
+      with:
+        redis-version: "7.x"
+      if: ${{ !!matrix.redis }}
+    - run: redis-cli ping
+      if: ${{ !!matrix.redis }}
+    - uses: actions/checkout@v4
     - uses: ruby/setup-ruby@v1
       with:
         ruby-version: ${{ matrix.ruby }}
         bundler-cache: true
-        bundler: ${{ matrix.bundler || 'default' }}
+    - run: bundle exec rake compile
     - run: bundle exec rake test
   javascript_test:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v3
-    - uses: ruby/setup-ruby@v1
+    - uses: actions/checkout@v4
+    - uses: actions/setup-node@v4
       with:
-        ruby-version: 2.7
-        bundler-cache: true
-    - run: bundle exec rake js:all
+        node-version: '21'
+    - run: npm ci
+      working-directory: ./javascript_client
+    - run: npm test
+      working-directory: ./javascript_client
   postgres_test:
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        include:
+        - gemfile: gemfiles/rails_master.gemfile
+          ruby: 3.3
+          isolation_level_fiber: 1
+        - gemfile: gemfiles/rails_7.1_postgresql.gemfile
+          ruby: 3.3
     services:
       postgres:
         image: postgres:latest
@@ -90,22 +121,25 @@ jobs:
           --health-timeout 5s
           --health-retries 5
     steps:
-    - run: echo BUNDLE_GEMFILE='gemfiles/rails_6.1_postgresql.gemfile' > $GITHUB_ENV
+    - run: echo BUNDLE_GEMFILE='' > $GITHUB_ENV
     - run: echo DATABASE='POSTGRESQL' > $GITHUB_ENV
     - run: echo PGPASSWORD='postgres' > $GITHUB_ENV
-    - uses: actions/checkout@v3
+    - run: echo GRAPHQL_CPARSER=1 > $GITHUB_ENV
+    - run: echo ISOLATION_LEVEL_FIBER=1 > $GITHUB_ENV
+      if: ${{ !!matrix.isolation_level_fiber }}
+    - uses: actions/checkout@v4
     - uses: ruby/setup-ruby@v1
       with:
-        ruby-version: 2.7
+        ruby-version: "3.3"
         bundler-cache: true
-    - run: bundle exec rake test
+    - run: bundle exec rake compile test
   mongodb_test:
     strategy:
       fail-fast: false
       matrix:
         gemfile:
-          - gemfiles/mongoid_6.gemfile
-          - gemfiles/mongoid_7.gemfile
+          - gemfiles/mongoid_9.gemfile
+          - gemfiles/mongoid_8.gemfile
     runs-on: ubuntu-latest
     services:
       mongodb:
@@ -114,9 +148,9 @@ jobs:
         - 27017:27017
     steps:
     - run: echo BUNDLE_GEMFILE=${{ matrix.gemfile }} > $GITHUB_ENV
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
     - uses: ruby/setup-ruby@v1
       with:
-        ruby-version: 2.7
+        ruby-version: 3.4
         bundler-cache: true
-    - run: bundle exec rake test
+    - run: bundle exec rake compile test

Diff for: .github/workflows/pronto.yaml

@@ -0,0 +1,22 @@
+name: Pronto
+on:
+  - pull_request_target
+
+jobs:
+  pronto:
+    runs-on: ubuntu-latest
+    steps:
+      - run: echo BUNDLE_GEMFILE=gemfiles/pronto.gemfile > $GITHUB_ENV
+      - name: Checkout code
+        uses: actions/checkout@v4
+      - run: git fetch --no-tags --prune --unshallow origin +refs/heads/*:refs/remotes/origin/*
+      - name: Setup Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 3.4
+          bundler-cache: true
+      - name: Run Pronto
+        run: bundle exec pronto run -f github_pr -c origin/${{ github.base_ref }}
+        env:
+          PRONTO_PULL_REQUEST_ID: ${{ github.event.pull_request.number }}
+          PRONTO_GITHUB_ACCESS_TOKEN: "${{ github.token }}"

Diff for: .github/workflows/website.yaml

@@ -1,7 +1,11 @@
 name: Publish Website
 on:
+  # For some reason, `on: release: ...` didn't work with `nektos/act`
   push:
-    branches: [master]
+    # Sequence of patterns matched against refs/tags
+    tags:
+      - 'v*' # Push events to matching v*, i.e. v1.0, v20.15.10
+  workflow_dispatch:
 
 permissions: {}
 jobs:
@@ -12,9 +16,9 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout master
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
       - name: Checkout GitHub pages branch
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           path: gh-pages
           ref: gh-pages
@@ -29,8 +33,8 @@ jobs:
           bundle exec rake site:fetch_latest site:build_doc site:update_search_index site:clean_html site:build_html
       - name: Commit changes as last committer
         run: |
-          git config --global user.name "%(git log --format="%aN" -n 1)"
-          git config --global user.email "%(git log --format="%aE" -n 1)"
+          git config --global user.name "$(git log --format="%aN" -n 1)"
+          git config --global user.email "$(git log --format="%aE" -n 1)"
           bundle exec rake site:commit_changes
       - name: Deploy to GitHub pages via gh-pages branch
         uses: s0/git-publish-subdir-action@master

Diff for: .gitignore

@@ -7,20 +7,25 @@ Gemfile.lock
 gemfiles/*.lock
 # Test database
 *.db
+*.db-shm
+*.db-wal
+*.sqlite3
+.byebug_history
 .bundle/
 vendor/
 .idea/
+coverage/
 
 _site
 .sass-cache
 .jekyll-metadata
 .jekyll-cache
 gh-pages/
 tmp/*
-__*.db
 node_modules/
 yarn.lock
 OperationStoreClient.js
+DumpPayloadExample.json
 spec/integration/tmp
 .vscode/
 *.swp
@@ -33,3 +38,8 @@ javascript_client/subscriptions
 javascript_client/sync
 javascript_client/cli*
 javascript_client/index*
+# Don't commit compiled extension files:
+*.bundle
+*.so
+# Ragel generates Ruby type hints which is great, but I'm not ready to support them
+*.ri

Diff for: .rubocop.yml

@@ -1,14 +1,16 @@
 require:
   - ./cop/development/none_without_block_cop
+  - ./cop/development/no_eval_cop
   - ./cop/development/no_focus_cop
   - ./lib/graphql/rubocop/graphql/default_null_true
   - ./lib/graphql/rubocop/graphql/default_required_true
   - ./cop/development/context_is_passed_cop
+  - ./cop/development/trace_methods_cop.rb
 
 AllCops:
   DisabledByDefault: true
   SuggestExtensions: false
-  TargetRubyVersion: 2.4
+  TargetRubyVersion: 2.7
   Exclude:
     - 'lib/graphql/language/lexer.rb'
     - 'lib/graphql/language/parser.rb'
@@ -22,21 +24,9 @@ Development/ContextIsPassedCop:
   Exclude:
     - 'spec/**/*'
     - 'cop/**/*'
-    # Legacy-related:
-    - 'lib/graphql/*_type.rb'
-    - 'lib/graphql/define/**/*.rb'
-    - 'lib/graphql/relay/**/*'
-    - 'lib/graphql/function.rb'
-    - 'lib/graphql/directive.rb'
-    - 'lib/graphql/field.rb'
-    - 'lib/graphql/schema/traversal.rb'
-    - 'lib/graphql/schema/possible_types.rb'
     - 'lib/graphql/schema/validation.rb'
-    - 'lib/graphql/compatibility/**/*'
-    - 'lib/graphql/static_validation/type_stack.rb'
     - 'lib/graphql/static_validation/literal_validator.rb'
     - 'lib/graphql/static_validation/rules/**/*.rb'
-    - 'lib/graphql/internal_representation/**/*.rb'
     # AST-related:
     - 'lib/graphql/schema/build_from_definition.rb'
     - 'lib/graphql/language/printer.rb'
@@ -52,10 +42,19 @@ Development/NoneWithoutBlockCop:
     - "lib/**/*"
     - "spec/**/*"
 
+Development/NoEvalCop:
+  Include:
+    - "lib/**/*"
+
 Development/NoFocusCop:
   Include:
     - "spec/**/*"
 
+Development/TraceMethodsCop:
+  Include:
+    - "lib/graphql/tracing/perfetto_trace.rb"
+    - "lib/graphql/tracing/notifications_trace.rb"
+
 # def ...
 # end
 Layout/DefEndAlignment: