Skip to content

Query params unparsable due to fragment manipulation #130

@soverysour

Description

@soverysour

Hi,

due to how the url is manipulated (links are prepended with "#/" instead of "/", the url is updated to overwrite the path with the fragment), query parameters cannot be parsed (the "#" fragment starter eats all the remaining tokens up, and doesn't do query param parsing.

Removing in Main the case match on the fragment, the "#/ to "/" in Route and the url update also in Route fixes this, but I'm assuming this (the manipulation of the path as a fragment) was a workaround for webpack? Since, after doing the above 3 changes, going to a path like /something/something-deeper triggers errors related to /something/vendor.js and /something/main.js (IIRC, it's main.js).

What do you think @romariolopezc ? IMO it's better to have it without the fragment magic, so as to be able to manipulate query params properly. I haven't looked further into the other webpack magic, so no clues there.

Metadata

Metadata

Assignees

No one assigned

    Labels

    questionFurther information is requested

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions