Include TS declarations in ts_library JsInfo

nevadaperry · nevadaperry · commit 5c3562c82918 · 2025-06-18T15:52:58.000Z
I don't understand this well. Claude Code stumbled upon it as a fix for
the regression we had after jumping from rules_js of August 2022 to
March 2025 in our main repo. The issue is we have a ts_library
containing .js, .js.map, and .d.ts files generated from X12 fixtures.
Updating our pin on rules_js caused those .d.ts files to stop getting
included in our node_modules_package target for VSCode type hints.
(Other ts_library and js_import_ts targets were fine).
diff --git a/ts-proto/rules.bzl b/ts-proto/rules.bzl
@@ -247,7 +247,7 @@ def _ts_proto_libraries_impl(ctx):
 
         js_infos[lib.label] = create_js_info(
             cjs_root = cjs_root,
-            files = js,
+            files = js + declarations,
             deps = ts_proto.deps_js + [js_infos[label] for label in lib.deps],
         )
 
diff --git a/typescript/rules.bzl b/typescript/rules.bzl
@@ -360,7 +360,7 @@ def _ts_library_impl(ctx):
     js_info = create_js_info(
         cjs_root = cjs_root,
         deps = js_deps + compiler.runtime_js,
-        files = js,
+        files = js + declarations,
     )
 
     ts_info = create_ts_info(

Original file line number	Diff line number	Diff line change
`@@ -247,7 +247,7 @@ def _ts_proto_libraries_impl(ctx):`
`247`	`247`
`248`	`248`	`js_infos[lib.label] = create_js_info(`
`249`	`249`	`cjs_root = cjs_root,`
`250`		`- files = js,`
	`250`	`+ files = js + declarations,`
`251`	`251`	`deps = ts_proto.deps_js + [js_infos[label] for label in lib.deps],`
`252`	`252`	`)`
`253`	`253`
Original file line number	Diff line number	Diff line change
`@@ -360,7 +360,7 @@ def _ts_library_impl(ctx):`
`360`	`360`	`js_info = create_js_info(`
`361`	`361`	`cjs_root = cjs_root,`
`362`	`362`	`deps = js_deps + compiler.runtime_js,`
`363`		`- files = js,`
	`363`	`+ files = js + declarations,`
`364`	`364`	`)`
`365`	`365`
`366`	`366`	`ts_info = create_ts_info(`