increasing coverage on transcript model (#181)

* increasing coverage on transcript model

* renaming spec description

Author: rodrigoassis

app/models/institution.rb

@@ -25,9 +25,7 @@ class Institution < ApplicationRecord
 
   validate :image_size_restriction
 
-  HUMANIZED_ATTRIBUTES = {
-    :slug => "UID"
-  }
+  HUMANIZED_ATTRIBUTES = { slug: "UID" }
 
   scope :order_asc, -> { order("LOWER(institutions.name)") }
 
@@ -63,31 +61,29 @@ def self.state_library_nsw
 
   def self.all_institution_disk_usage
     Rails.cache.fetch("Institution:disk_usage:all", expires_in: 48.hours) do
-      Institution.all.map { |i| i.disk_usage }
-        .inject({ image: 0, audio: 0, script: 0 }) do |memo, tu|
-          memo[:image] += tu[:image]
-          memo[:audio] += tu[:audio]
-          memo[:script] += tu[:script]
-          memo
-        end
+      Institution.all.map(&:disk_usage).inject({ image: 0, audio: 0, script: 0 }) do |memo, tu|
+        memo[:image] += tu[:image]
+        memo[:audio] += tu[:audio]
+        memo[:script] += tu[:script]
+        memo
+      end
     end
   end
 
   def duration
-    Rails.cache.fetch("Institution:duration:#{self.id}", expires_in: 23.hours) do
+    Rails.cache.fetch("Institution:duration:#{id}", expires_in: 23.hours) do
       collections.map(&:duration).inject(0) { |memo, duration| memo + duration }
     end
   end
 
   def disk_usage
-    Rails.cache.fetch("Institution:disk_usage:#{self.id}", expires_in: 23.hours) do
-      collections.map(&:disk_usage)
-        .inject({ image: 0, audio: 0, script: 0 }) do |memo, tu|
-          memo[:image] += tu[:image]
-          memo[:audio] += tu[:audio]
-          memo[:script] += tu[:script]
-          memo
-        end
+    Rails.cache.fetch("Institution:disk_usage:#{id}", expires_in: 23.hours) do
+      collections.map(&:disk_usage).inject({ image: 0, audio: 0, script: 0 }) do |memo, tu|
+        memo[:image] += tu[:image]
+        memo[:audio] += tu[:audio]
+        memo[:script] += tu[:script]
+        memo
+      end
     end
   end
 

app/services/azure/speech_to_text_service.rb

@@ -41,11 +41,11 @@ def wav_file
     # Convert the file to what azure speech-to-text javascript SDK requires
     # @see speech-to-text.js
     def convert_audio_to_wav
-      stdout, stderr, status =
-        Open3.capture3("ffmpeg", "-i", file.to_s, "-ac", "1", "-ar", "16000", wav_file)
+      _stdout, stderr, status = Open3.capture3("ffmpeg", "-i", file.to_s, "-ac", "1", "-ar", "16000", wav_file)
       raise Exception, stderr unless status.success?
+
       Rails.logger.debug("--- convert_audio_to_wav ---")
-      Rails.logger.debug(File.size wav_file) if File.exist? wav_file
+      Rails.logger.debug(File.size(wav_file)) if File.exist? wav_file
     end
 
     def transcripts_from_sdk
@@ -58,6 +58,7 @@ def transcripts_from_sdk
       Rails.logger.debug(stdout)
       Rails.logger.debug(stderr)
       raise Exception, stderr.presence || stdout unless status.success?
+
       stdout
     end
 

app/services/voice_base/import_srt_transcripts.rb

@@ -22,21 +22,18 @@ def update_from_voicebase(transcript, contents)
       update_records(transcript, contents.lines)
     end
 
-
     private
 
     def call
       # Retrieve empty transcripts that have VoiceBase as their vendor.
       transcripts = Transcript.getForDownloadByVendor('voice_base', @project_id)
-      puts "Retrieved #{transcripts.count} empty transcripts from collections \
-      with VoiceBase as their vendor."
+      Rails.logger.info("Retrieved #{transcripts.count} empty transcripts from collections with VoiceBase as their vendor.")
 
       transcripts.find_each { |transcript| load_from_file(transcript) }
     end
 
     def transcript_file_path(transcript)
-      Rails.root.join('project', @project_id, 'transcripts', 'voice_base',
-                      "#{transcript.vendor_identifier}.srt")
+      Rails.root.join('project', @project_id, 'transcripts', 'voice_base', "#{transcript.vendor_identifier}.srt")
     end
 
     # Read lines from a single transcript.
@@ -45,8 +42,7 @@ def read_lines_from_file(transcript)
       if transcript.script.file.nil?
         fp = transcript_file_path(transcript)
         unless File.exist?(fp)
-          puts "Couldn't find transcript in project folder for Transcript \
-          ##{transcript.id} at #{fp}."
+          Rails.logger.info("Couldn't find transcript in project folder for Transcript ##{transcript.id} at #{fp}.")
           return []
         end
         File.read(fp).lines
@@ -70,12 +66,12 @@ def update_records(transcript, contents)
         debug = "Created #{transcript_lines.length} lines from \
         transcript #{transcript.uid}."
       end
-      puts debug
+      Rails.logger.info(debug)
     end
 
     # Ingest processed lines into the transcript.
     def ingest_transcript_lines(transcript, transcript_lines)
-      return nil if transcript_lines.nil? or transcript_lines.empty?
+      return nil if transcript_lines.nil? || transcript_lines.empty?
 
       TranscriptLine.where(transcript_id: transcript.id).destroy_all
       TranscriptLine.create!(transcript_lines)

config/environments/staging.rb

@@ -1,5 +1,5 @@
 Rails.application.configure do
- ENV["DEFAULT_MAILER_HOST"] # Settings specified here will take precedence over those in config/application.rb.
+  ENV["DEFAULT_MAILER_HOST"] # Settings specified here will take precedence over those in config/application.rb.
 
   # Code is not reloaded between requests.
   config.cache_classes = true

spec/features/admin/summary_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-RSpec.feature 'Summary Page' do
+RSpec.describe 'Summary Page', type: :feature do
   let(:admin) { create(:user, :admin) }
 
   describe 'the Summary page as an admin', js: true do

spec/models/transcripts_spec.rb renamed to spec/models/transcript_spec.rb

@@ -24,6 +24,7 @@
   end
 
   describe "scopes" do
+    let(:user) { create(:user) }
     let!(:completed_trasncript) { create :transcript, percent_completed: 100 }
     let!(:reviewing_trasncript) { create :transcript, percent_reviewing: 37 }
     let!(:not_completed_trasncript) { create :transcript, percent_edited: 37 }
@@ -39,12 +40,24 @@
     it "gets pending" do
       expect(described_class.pending.to_a).to eq([not_completed_trasncript])
     end
+
+    it 'gets edited' do
+      expect(described_class.getEdited).to eq([])
+    end
+
+    it 'gets user edited' do
+      expect(described_class.getByUserEdited(user.id)).to eq([])
+    end
+  end
+
+  it "returns .seconds_per_line" do
+    expect(described_class.seconds_per_line).to eq(5)
   end
 
   describe "validate uid does not change after create" do
     let(:vendor) { Vendor.create!(uid: "voice_base", name: "VoiceBase") }
     let(:transcript) do
-      Transcript.new(
+      described_class.new(
         uid: "transcript_test",
         vendor_id: vendor.id,
       )
@@ -64,6 +77,22 @@
     end
   end
 
+  describe "#transcription_conventions" do
+    let(:transcript) { create(:transcript) }
+
+    it "returns conventions" do
+      expect(transcript.transcription_conventions.size).to eq(8)
+    end
+  end
+
+  describe "#to_param" do
+    let(:transcript) { create(:transcript) }
+
+    it "returns uid" do
+      expect(transcript.to_param).to eq(transcript.uid)
+    end
+  end
+
   describe "#speakers" do
     let(:vendor) { Vendor.create(uid: "voice_base", name: "VoiceBase") }
     let(:institution) { FactoryBot.create :institution }
@@ -78,7 +107,7 @@
       )
     end
     let(:transcript) do
-      Transcript.create!(
+      described_class.create!(
         uid: "test_transcript",
         vendor: vendor,
         collection: collection,
@@ -148,17 +177,21 @@
   describe "#get_for_home_page" do
     let(:collection) { create :collection, :published }
     let(:params) do
-      { collections: [collection.title], sort_by: sort_by,
-      search: "", institution: nil, theme: [""] }
+      {
+        collections: [collection.title], sort_by: sort_by, search: "", institution: nil, theme: [""]
+      }
     end
 
     before do
       %w[B A].each do |title|
-        create :transcript, :published,
+        create(
+          :transcript,
+          :published,
           title: title,
           collection: collection,
           project_uid: "nsw-state-library-amplify",
           lines: 1
+        )
       end
     end
 
@@ -175,7 +208,7 @@
       let!(:sort_by) { "" } # blank means random
 
       it "return random records" do
-        expect(Transcript).to receive(:randomize_list)
+        expect(described_class).to receive(:randomize_list)
         described_class.get_for_home_page(params)
       end
     end
@@ -216,9 +249,7 @@
       end
 
       it "shows theme1 records" do
-        expect(described_class.search({
-          theme: ["theme1"],
-        })).to eq([transcript2])
+        expect(described_class.search({ theme: ["theme1"] })).to eq([transcript2])
       end
     end
   end