Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/e2e/proto_all_project_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ func TestGetAllProjects(t *testing.T) {
// Update project metadata with topics
_, err := client.UpdateProjectMetadata(ctx, &pb.UpdateProjectMetadataRequest{
ProjectId: res.Project.Id,
Topics: projectTopics[res.Project.Id],
Topics: &pb.Topics{Values: projectTopics[res.Project.Id]},
})
require.NoError(t, err)
}
Expand Down
86 changes: 73 additions & 13 deletions server/e2e/proto_project_metadata_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,19 +32,79 @@ func TestInternalAPI_metadata_update(t *testing.T) {
},
)

// update metadata
res := UpdateProjectMetadata(
t, ctx, r, client,
&pb.UpdateProjectMetadataRequest{
ProjectId: projectID.String(),
Readme: lo.ToPtr("test readme"),
License: lo.ToPtr("test license"),
Topics: []string{"test topics"},
},
)
assert.Equal(t, "test readme", *res.Readme)
assert.Equal(t, "test license", *res.License)
assert.Equal(t, []string{"test topics"}, res.Topics)
t.Run("update with normal topics", func(t *testing.T) {
res := UpdateProjectMetadata(
t, ctx, r, client,
&pb.UpdateProjectMetadataRequest{
ProjectId: projectID.String(),
Readme: lo.ToPtr("test readme"),
License: lo.ToPtr("test license"),
Topics: &pb.Topics{Values: []string{"test topics"}},
},
)
assert.Equal(t, "test readme", *res.Readme)
assert.Equal(t, "test license", *res.License)
assert.Equal(t, []string{"test topics"}, res.Topics)
})

t.Run("topics should be empty after deletion", func(t *testing.T) {
res := UpdateProjectMetadata(
t, ctx, r, client,
&pb.UpdateProjectMetadataRequest{
ProjectId: projectID.String(),
Readme: lo.ToPtr("test readme 2"),
License: lo.ToPtr("test license 2"),
Topics: &pb.Topics{Values: []string{}},
},
)
assert.Equal(t, "test readme 2", *res.Readme)
assert.Equal(t, "test license 2", *res.License)
assert.Nil(t, res.Topics)
})

t.Run("update with nil topics", func(t *testing.T) {
res := UpdateProjectMetadata(
t, ctx, r, client,
&pb.UpdateProjectMetadataRequest{
ProjectId: projectID.String(),
Readme: lo.ToPtr("test readme 3"),
License: lo.ToPtr("test license 3"),
},
)
assert.Equal(t, "test readme 3", *res.Readme)
assert.Equal(t, "test license 3", *res.License)
assert.Nil(t, res.Topics)
})

t.Run("update with multiple topics", func(t *testing.T) {
res := UpdateProjectMetadata(
t, ctx, r, client,
&pb.UpdateProjectMetadataRequest{
ProjectId: projectID.String(),
Readme: lo.ToPtr("test readme 4"),
License: lo.ToPtr("test license 4"),
Topics: &pb.Topics{Values: []string{"topic1", "topic2", "topic3"}},
},
)
assert.Equal(t, "test readme 4", *res.Readme)
assert.Equal(t, "test license 4", *res.License)
assert.Equal(t, []string{"topic1", "topic2", "topic3"}, res.Topics)
})

t.Run("handle duplicate and empty string in topics", func(t *testing.T) {
res := UpdateProjectMetadata(
t, ctx, r, client,
&pb.UpdateProjectMetadataRequest{
ProjectId: projectID.String(),
Readme: lo.ToPtr("test readme 4"),
License: lo.ToPtr("test license 4"),
Topics: &pb.Topics{Values: []string{"topic1", "topic1", "topic2", "", "topic3"}},
},
)
assert.Equal(t, "test readme 4", *res.Readme)
assert.Equal(t, "test license 4", *res.License)
assert.Equal(t, []string{"topic1", "topic2", "topic3"}, res.Topics)
})
})
}

Expand Down
2 changes: 1 addition & 1 deletion server/e2e/proto_project_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ func TestInternalAPI_unit(t *testing.T) {
ProjectId: pid.String(),
Readme: lo.ToPtr("test readme"),
License: lo.ToPtr("test license"),
Topics: []string{"test topics"},
Topics: &pb.Topics{Values: []string{"test topics"}},
},
)
res, err := client.GetProjectList(ctx, &pb.GetProjectListRequest{
Expand Down
Loading