Skip to content

Commit ab1f902

Browse files
committed
fixes for building docker image from git tag
1 parent c5d8112 commit ab1f902

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,12 +72,14 @@ jobs:
7272
run: |
7373
export TARGET=opengl
7474
export UBUNTU=${{ matrix.ubuntu }}
75+
export TAG=ghcr.io/rectalogic/renderwindow:${UBUNTU}-${{ github.ref_name }}
7576
builders/Linux/docker-run.sh
7677
- name: Build renderwindow vulkan
7778
if: matrix.ubuntu == 'noble'
7879
run: |
7980
export TARGET=vulkan
8081
export UBUNTU=${{ matrix.ubuntu }}
82+
export TAG=ghcr.io/rectalogic/renderwindow:${UBUNTU}-${{ github.ref_name }}
8183
builders/Linux/docker-run.sh
8284
- name: Archive
8385
id: archive

builders/Linux/docker-build.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,5 @@ if [[ ! $QTACCOUNT ]]; then
1818
fi
1919
fi
2020

21-
docker buildx build --secret id=qtaccount,src="$QTACCOUNT" --build-arg UBUNTU=${UBUNTU:-noble} --build-arg QT_VER=${QT_VER:?} --build-arg QT_INSTALLER_VER=${QT_INSTALLER_VER:?} --platform linux/amd64 --memory-swap -1 --load --tag ghcr.io/rectalogic/renderwindow:${UBUNTU:-noble}-$(git branch --show-current) --file "${CURRENT}/Dockerfile" "${CURRENT}/.."
21+
TAG=${TAG:-ghcr.io/rectalogic/renderwindow:${UBUNTU:-noble}-$(git branch --show-current)}
22+
docker buildx build --secret id=qtaccount,src="$QTACCOUNT" --build-arg UBUNTU=${UBUNTU:-noble} --build-arg QT_VER=${QT_VER:?} --build-arg QT_INSTALLER_VER=${QT_INSTALLER_VER:?} --platform linux/amd64 --memory-swap -1 --load --tag ${TAG} --file "${CURRENT}/Dockerfile" "${CURRENT}/.."

builders/Linux/docker-run.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,6 @@ MOUNT="$(cd "${BASH_SOURCE%/*}/../.."; pwd)"
66

77
# opengl or vulkan
88
TARGET=${TARGET:-opengl}
9+
TAG=${TAG:-ghcr.io/rectalogic/renderwindow:${UBUNTU:-noble}-$(git branch --show-current)}
910
docker run ${DOCKER_OPTS} -e QSG_RHI_BACKEND=${TARGET} --rm --init \
10-
--mount="type=bind,src=${MOUNT},dst=/renderwindow,consistency=cached" ghcr.io/rectalogic/renderwindow:${UBUNTU:-noble}-$(git branch --show-current) "$@"
11+
--mount="type=bind,src=${MOUNT},dst=/renderwindow,consistency=cached" ${TAG} "$@"

0 commit comments

Comments
 (0)