Logging might be broken-ish

[agjohnson]

I had a hard time debugging an issue with my instance, an exception was being thrown in a templatetag and this didn't cause an exception but instead caused the template block to just not render.

I had to delete template code until I found the template code that was causing the block to not render. There is probably an easier way to repro this, but describing what I noticed:

• Run latest main on repos
• Open an application templatetag and thrown an exception from the template filter/tag
• Use the filter/tag in a template
• You should notice no exception or logging and the template content block is just empty instead.

Running on 14.2.0+13.1.0 tags I notice errors again and debug toolbar response is the verbose exception page.

• Maybe related to recent Upgrade django-structlog to its latest version #12302

[humitos]

Don't we need a specific config to raise a breaking exception when an exception happens inside the template logic? I remember we had a similar issue in the past -- maybe we lost this configuration when dealing with settings.

[agjohnson]

I'm not familiar, with the Django handler I don't believe you need anything additional. This logging was working before I bumped to the lastest commits and works on the last release, 14.2.0+13.1.0, so something recently broke this. The structlog upgrade looks like the most obvious culprit, so if there was a setting missed it would be a setting that was required as part of the upgrade.

[humitos]

I'm not able to reproduce this. With the following change

diff --git a/readthedocsext/theme/templatetags/ext_theme_tags.py b/readthedocsext/theme/templatetags/ext_theme_tags.py
index 4346bd2..92f8028 100644
--- a/readthedocsext/theme/templatetags/ext_theme_tags.py
+++ b/readthedocsext/theme/templatetags/ext_theme_tags.py
@@ -54,6 +54,8 @@ def do_webpack_static(parser, token):
 
     Extended from Django ``static`` templatetag.
     """
+    raise Exception
+
     return WebpackStaticNode.handle_token(parser, token)

I get the exception properly reported in the browser:

[agjohnson]

I tested this too and wasn't able to reproduce with a basic exception. It seems the only case so far that can reproduce this issue is specifically a model not found exception being thrown in the get_providers template tag. This causes the templates to silently fail to render for some reason.

The fix was here: https://github.com/readthedocs/readthedocs-corporate/pull/2019

[humitos]

We can close this issue since one part of this was fixed and the other part was not possible to replicate.