fix(states): do not set state to done if it was changed since progress

Author: Murat

src/__tests__/unit/utils/setState.spec.ts

@@ -5,16 +5,24 @@ import { setState } from '../../../utils/setState';
 import { variables } from '../../../variables';
 
 describe('setState', () => {
-  it('should not set state to done if it is not progress', () => {
+  it('should set state to done if it is progress', () => {
     variables.clear();
-    variables.set('test', {
-      state: 'skipped',
-    } as TaskState);
+    setState('test', {
+      state: 'progress',
+    });
     setState('test', {
       state: 'done',
     });
-    expect(variables.get<TaskState>('test')).toEqual({
+    expect(variables.get<TaskState['state']>('test')).toEqual('done');
+  });
+  it('should not set state to done if it is not progress', () => {
+    variables.clear();
+    setState('test', {
       state: 'skipped',
     });
+    setState('test', {
+      state: 'done',
+    });
+    expect(variables.get<TaskState['state']>('test')).toEqual('skipped');
   });
 });

src/utils/setState.ts

@@ -4,8 +4,8 @@ import { variables } from '../variables';
 export function setState(name: string | undefined, state: TaskState): void {
   if (name) {
     if (state.state == 'done') {
-      const currentState = variables.get<TaskState>(name);
-      if (currentState && currentState.state != 'progress') return;
+      const currentState = variables.get<TaskState['state']>(name);
+      if (currentState && currentState != 'progress') return;
     }
     variables.set(name, state.state);
     variables.set('reason.' + name, state.reason);

website/docs/guides/states.md

@@ -46,7 +46,7 @@ steps:
 
   - task: build_gradle
     when:
-      fs_google.state: done
+      fs_google: done
 ```
 
 In this example, we have two tasks. The first task, `fs_google`, has a name assigned to it. The second task, `build_gradle`, uses the `when` condition to check the state of the `fs_google` task. It will only execute when the `fs_google` task is in the `done` state (completed successfully).