fix: ask if user wants to continue with outdated version

Author: Murat Mehmet

.eslintrc.js

@@ -16,6 +16,7 @@ module.exports = {
   ],
   rules: {
     'no-console': ['error', { allow: ['warn', 'error'] }],
+    'no-process-exit': 'off',
     'prettier/prettier': 'warn',
     'node/no-missing-import': 'off',
     'node/no-empty-function': 'off',

src/__tests__/mocks/mockAll.ts

@@ -15,8 +15,8 @@ import { mockPList } from './mockPList';
 import { notificationServiceM as mockNotificationServiceTemplate } from '../../scaffold/notification-service/notificationServiceM';
 import { notificationViewControllerM as mockNotificationContentTemplate } from '../../scaffold/notification-content/notificationViewControllerM';
 
-jest.spyOn(process, 'abort').mockImplementation(() => {
-  throw new Error('program aborted');
+jest.spyOn(process, 'exit').mockImplementation(() => {
+  throw new Error('program exited');
 });
 
 function writeMockProject(

src/__tests__/unit/prompter.spec.ts

@@ -173,7 +173,7 @@ describe('prompter', () => {
 
     await expect(async () => {
       await confirm('test');
-    }).rejects.toThrowError('program aborted');
+    }).rejects.toThrowError('program exited');
 
     expect(mockPrompter.confirm).toHaveBeenCalled();
   });
@@ -186,7 +186,7 @@ describe('prompter', () => {
 
     await expect(async () => {
       await text('test');
-    }).rejects.toThrowError('program aborted');
+    }).rejects.toThrowError('program exited');
 
     expect(mockPrompter.text).toHaveBeenCalled();
   });
@@ -202,7 +202,7 @@ it('should cancel multiselect', async () => {
     multiselect('test', {
       options: [{ value: 'opt1' }, { value: 'opt2' }],
     })
-  ).rejects.toThrowError('program aborted');
+  ).rejects.toThrowError('program exited');
 
   expect(mockPrompter.multiselect).toHaveBeenCalled();
 });
@@ -217,7 +217,7 @@ it('should cancel select', async () => {
     select('test', {
       options: [{ value: 'opt1' }, { value: 'opt2' }],
     })
-  ).rejects.toThrowError('program aborted');
+  ).rejects.toThrowError('program exited');
 
   expect(mockPrompter.select).toHaveBeenCalled();
 });

src/__tests__/unit/utils/checkForUpdate.spec.ts

@@ -9,6 +9,9 @@ jest.mock('../../../../package.json', () => ({
   version: '1.0.0',
   name: 'react-native-integrate',
 }));
+jest.spyOn(process, 'exit').mockImplementation(() => {
+  throw new Error('program exited');
+});
 
 describe('checkForUpdate', () => {
   beforeEach(() => {

src/__tests__/unit/utils/getInstalledPackages.spec.ts

@@ -27,6 +27,6 @@ describe('getInstalledPackages', () => {
 
     expect(() => {
       getInstalledPackages();
-    }).toThrowError('program aborted');
+    }).toThrowError('program exited');
   });
 });

src/__tests__/unit/utils/updateIntegrationStatus.spec.ts

@@ -133,7 +133,7 @@ describe('updateIntegrationStatus', () => {
       },
     });
   });
-  it('should abort for unsupported lock file version', () => {
+  it('should exit for unsupported lock file version', () => {
     // @ts-ignore
     // eslint-disable-next-line @typescript-eslint/no-empty-function
 
@@ -152,9 +152,9 @@ describe('updateIntegrationStatus', () => {
           },
         },
       ]);
-    }).toThrowError('program aborted');
+    }).toThrowError('program exited');
   });
-  it('should abort when has no read permission', () => {
+  it('should exit when has no read permission', () => {
     mockFs.setReadPermission(false);
     // @ts-ignore
     // eslint-disable-next-line @typescript-eslint/no-empty-function
@@ -174,9 +174,9 @@ describe('updateIntegrationStatus', () => {
           },
         },
       ]);
-    }).toThrowError('program aborted');
+    }).toThrowError('program exited');
   });
-  it('should abort when has no write permission', () => {
+  it('should exit when has no write permission', () => {
     mockFs.setWritePermission(false);
     // @ts-ignore
     // eslint-disable-next-line @typescript-eslint/no-empty-function
@@ -190,6 +190,6 @@ describe('updateIntegrationStatus', () => {
           },
         },
       ]);
-    }).toThrowError('program aborted');
+    }).toThrowError('program exited');
   });
 });

src/prompter.ts

@@ -119,7 +119,7 @@ export async function multiselect(
   });
   if (isCancel(response)) {
     cancel('operation cancelled');
-    process.abort();
+    process.exit(0);
   }
   if (isProgressActive) progress.display();
   // @ts-ignore
@@ -144,7 +144,7 @@ export async function select(
   });
   if (isCancel(response)) {
     cancel('operation cancelled');
-    process.abort();
+    process.exit(0);
   }
   if (isProgressActive) progress.display();
   // @ts-ignore
@@ -165,7 +165,7 @@ export async function confirm(
   });
   if (isCancel(response)) {
     cancel('operation cancelled');
-    process.abort();
+    process.exit(0);
   }
   if (isProgressActive) progress.display();
   return response;
@@ -186,7 +186,7 @@ export async function text(
   });
   if (isCancel(response)) {
     cancel('operation cancelled');
-    process.abort();
+    process.exit(0);
   }
   if (isProgressActive) progress.display();
   return response;

src/upgrade.ts

@@ -546,11 +546,6 @@ export async function upgrade(): Promise<void> {
 
     if (!options.get().verbose) {
       progress.hide();
-      if (!didPushFail) {
-        logSuccess(
-          color.green(`changes committed to ${color.bold(branchName)}`)
-        );
-      }
     }
   }
 }

src/utils/checkForUpdate.ts

@@ -1,6 +1,6 @@
 import color from 'picocolors';
 import semver from 'semver/preload';
-import { logWarning } from '../prompter';
+import { confirm, logWarning } from '../prompter';
 import { PackageJsonType } from '../types/mod.types';
 import { runCommand } from './runCommand';
 
@@ -26,6 +26,11 @@ export async function checkForUpdate(): Promise<void> {
           `Current: ${color.gray(currentVersion)} | Latest: ${color.green(latestVersion)}\n` +
           `${color.yellow('Run')} ${color.blue(`npm install -g ${name}@latest`)} to update.`
       );
+      if (
+        !(await confirm('would you like to continue with outdated version?'))
+      ) {
+        process.exit(0);
+      }
     }
   } catch (_error) {
     /* empty */

src/utils/getInstalledPackages.ts

@@ -14,7 +14,7 @@ export function getInstalledPackages(): PackageTuples {
     } as Record<string, any>) as PackageTuples;
   } catch (error) {
     console.error('Error fetching installed packages:', error);
-    process.abort();
+    process.exit(0);
   }
 }
 

src/utils/getIntegrateConfig.ts

@@ -18,7 +18,7 @@ export function getIntegrateConfig(projectPath?: string) {
     return 'default' in config ? config.default : config;
   } catch (error) {
     console.error('Error reading integrate.config.js:', error);
-    process.abort();
+    process.exit(0);
   }
 }
 

src/utils/updateIntegrationStatus.ts

@@ -35,15 +35,15 @@ export function readLockFile(): LockDataWithMeta {
       console.error(
         `Error reading integrate-lock.json: lockfileVersion is not equal to ${Constants.CURRENT_LOCK_VERSION}`
       );
-      process.abort();
+      process.exit(0);
     }
     return {
       lockData,
       justCreated: false,
     };
   } catch (error) {
     console.error('Error reading integrate-lock.json:', error);
-    process.abort();
+    process.exit(0);
   }
 }
 
@@ -54,7 +54,7 @@ function writeLockFile(data: LockData): void {
     fs.writeFileSync(lockFilePath, JSON.stringify(data, null, 2));
   } catch (error) {
     console.error('Error writing integrate-lock.json:', error);
-    process.abort();
+    process.exit(0);
   }
 }