Skip to content

Commit 7cbce21

Browse files
authored
fix missing return statements for sqlite3 and aiosqlite (#31)
* fix(driver): add missing return statement in aiosqlite and sqlite3 drivers (bugfix/missing-return-sqlite) * changelog
1 parent cb538dc commit 7cbce21

File tree

3 files changed

+12
-6
lines changed

3 files changed

+12
-6
lines changed
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
kind: Fixed
2+
body: Missing return statements for `:execresult`, `:execrows` and `:execlastid` for `aiosqlite` and `sqlite3`
3+
time: 2025-05-05T22:21:54.7215073+02:00
4+
custom:
5+
Author: rayakame
6+
PR: "31"

internal/codegen/drivers/aiosqlite.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,17 +34,17 @@ func AioSQLiteBuildPyQueryFunc(query *core.Query, body *builders.IndentStringBui
3434
body.WriteLine(")")
3535
} else if query.Cmd == metadata.CmdExecResult {
3636
body.WriteLine(fmt.Sprintf(") -> %s:", "aiosqlite.Cursor"))
37-
body.WriteIndentedString(indentLevel+1, fmt.Sprintf("await %s.execute(%s", conn, query.ConstantName))
37+
body.WriteIndentedString(indentLevel+1, fmt.Sprintf("return await %s.execute(%s", conn, query.ConstantName))
3838
aiosqliteWriteParams(query, body)
3939
body.WriteLine(")")
4040
} else if query.Cmd == metadata.CmdExecRows {
4141
body.WriteLine(fmt.Sprintf(") -> %s:", retType))
42-
body.WriteIndentedString(indentLevel+1, fmt.Sprintf("await %s.execute(%s", conn, query.ConstantName))
42+
body.WriteIndentedString(indentLevel+1, fmt.Sprintf("return await %s.execute(%s", conn, query.ConstantName))
4343
aiosqliteWriteParams(query, body)
4444
body.WriteLine(").rowcount")
4545
} else if query.Cmd == metadata.CmdExecLastId {
4646
body.WriteLine(fmt.Sprintf(") -> %s:", retType))
47-
body.WriteIndentedString(indentLevel+1, fmt.Sprintf("await %s.execute(%s", conn, query.ConstantName))
47+
body.WriteIndentedString(indentLevel+1, fmt.Sprintf("return await %s.execute(%s", conn, query.ConstantName))
4848
aiosqliteWriteParams(query, body)
4949
body.WriteLine(").lastrowid")
5050
} else if query.Cmd == metadata.CmdOne {

internal/codegen/drivers/sqlite3.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,17 +34,17 @@ func SQLite3BuildPyQueryFunc(query *core.Query, body *builders.IndentStringBuild
3434
body.WriteLine(")")
3535
} else if query.Cmd == metadata.CmdExecResult {
3636
body.WriteLine(fmt.Sprintf(") -> %s:", "sqlite3.Cursor"))
37-
body.WriteIndentedString(indentLevel+1, fmt.Sprintf("%s.execute(%s", conn, query.ConstantName))
37+
body.WriteIndentedString(indentLevel+1, fmt.Sprintf("return %s.execute(%s", conn, query.ConstantName))
3838
sqlite3WriteParams(query, body)
3939
body.WriteLine(")")
4040
} else if query.Cmd == metadata.CmdExecRows {
4141
body.WriteLine(fmt.Sprintf(") -> %s:", retType))
42-
body.WriteIndentedString(indentLevel+1, fmt.Sprintf("%s.execute(%s", conn, query.ConstantName))
42+
body.WriteIndentedString(indentLevel+1, fmt.Sprintf("return %s.execute(%s", conn, query.ConstantName))
4343
sqlite3WriteParams(query, body)
4444
body.WriteLine(").rowcount")
4545
} else if query.Cmd == metadata.CmdExecLastId {
4646
body.WriteLine(fmt.Sprintf(") -> %s:", retType))
47-
body.WriteIndentedString(indentLevel+1, fmt.Sprintf("%s.execute(%s", conn, query.ConstantName))
47+
body.WriteIndentedString(indentLevel+1, fmt.Sprintf("return %s.execute(%s", conn, query.ConstantName))
4848
sqlite3WriteParams(query, body)
4949
body.WriteLine(").lastrowid")
5050
} else if query.Cmd == metadata.CmdOne {

0 commit comments

Comments
 (0)