AMQP 1.0: attaching a link with a JS-based client runs into a function_clause

[BlitzInternet]

Describe the bug

I'm trying out amqp1.0 with rhea and during the first steps I managed to cause this internal error:

Disconnected due to error: SessionError: function_clause
[{rabbit_amqp_session,handle_attach,
     [{'v1_0.attach',
          {utf8,<<"b1eb6064-5002-6f47-8e75-d094f713762a">>},
          {uint,0},
          true,undefined,undefined,undefined,
          {'v1_0.target',undefined,undefined,undefined,undefined,undefined,
              undefined,undefined},
          undefined,undefined,undefined,undefined,undefined,undefined,
          undefined},
      {state,
          {cfg,unlimited,<<"93d34c99-45b6-5645-a9c1-05271f09ade2">>,
              <0.757.0>,<0.760.0>,
              {user,<<"guest">>,
                  [administrator],
                  [{rabbit_auth_backend_internal,
                       #Fun<rabbit_auth_backend_internal.3.63536416>}]},
              <<"/">>,0,0,#{},none,<<"10.89.13.7:56582 -> 10.89.13.7:5672">>,
              255,400,170,256},
          0,400,4294967292,2048,4294967295,
          {[],[]},
          0,#{},#{},#{},#{},#{},#{},[],[],[],[],
          {rabbit_queue_type,#{}},
          [],[]}],
     [{file,"src/rabbit_amqp_session.erl"},{line,1186}]},
 {rabbit_amqp_session,handle_cast,2,
     [{file,"src/rabbit_amqp_session.erl"},{line,539}]},
 {gen_server,try_handle_cast,3,[{file,"gen_server.erl"},{line,2371}]},
 {gen_server,handle_msg,6,[{file,"gen_server.erl"},{line,2433}]},
 {proc_lib,init_p_do_apply,3,[{file,"proc_lib.erl"},{line,329}]}]
    at EventEmitter.Session.on_end (/opt/projects/zdb/Utilities/rmqadapter/node_modules/rhea/lib/session.js:702:86)
    at EventEmitter.Connection.<computed> [as on_end] (/opt/projects/zdb/Utilities/rmqadapter/node_modules/rhea/lib/connection.js:856:29)
    at Object.c.dispatch (/opt/projects/zdb/Utilities/rmqadapter/node_modules/rhea/lib/types.js:948:32)
    at Object.Transport.read (/opt/projects/zdb/Utilities/rmqadapter/node_modules/rhea/lib/transport.js:117:36)
    at Object.SaslClient.read (/opt/projects/zdb/Utilities/rmqadapter/node_modules/rhea/lib/sasl.js:344:26)
    at EventEmitter.Connection.input (/opt/projects/zdb/Utilities/rmqadapter/node_modules/rhea/lib/connection.js:568:37)
    at Socket.emit (node:events:507:28)
    at Socket.emit (node:domain:489:12)
    at addChunk (node:internal/streams/readable:559:12)
    at readableAddChunkPushByteMode (node:internal/streams/readable:510:3) {
  condition: 'amqp:internal-error',

Reproduction steps

1.run rmq 4 in docker:

version: '3.4'
services:

  messaging:
    image: rabbitmq:4.1.2-management-alpine
    ports:
      - 15672:15672
      - 5672:5672

2. run ts file:

import { describe, it } from 'node:test';
import type { Delivery, EventContext, Message, Container } from 'rhea';
import rhea from 'rhea'

describe('Rhea', () => {

	describe('Basics', () => {
		it('can connect to rmq4', async() => {
			const container = rhea.connect({
				username: 'guest',
				password: 'guest',
				host: '127.0.0.1',
				transport: 'tcp',
				port: 5672,
				reconnect: false
			});
			container.on('connection_open', (context: EventContext) => {
				console.log('Connected to RabbitMQ', context.container);
				context.connection.open_receiver({
					credit_window: 1,
					autoaccept: true,
					autosettle: true,

				});
			});

			container.on('receiver_open', () => {
				console.log('receiver link established');
			});
			container.on('message', (context: EventContext) => {
				console.log('message', context.message);
			});
			container.on('error', err => {
				console.error(err);
			})

			container.on('disconnected', (context: EventContext) => {
				if (context.error) {
					console.error('Disconnected due to error: %s', context.error);
				} else {
					console.log('Disconnected');
				}

				if (context.reconnecting) {
					console.log('Attempting to reconnect...');
				} else {
					console.log('Exiting');
				}
			});
		});
	});
});

Expected behavior

should log "receiver link established" without any error, or show error message of what went wrong.

Additional context

No response

[ansd]

When you attach a receiver, you need to define the source where to receive messages from.

[ansd]

See https://github.com/amqp/rhea/blob/e58161b2562434c3c74ed978b2a1a17d6c995134/examples/rabbitMQ/rabbitmq_receiver.js#L70-L75 for an example

[lukebakken]

@ansd do you think this situation could be common enough to return a friendlier error than function_clause with a stack?

handle_attach(#'v1_0.attach'{
                source = undefined,
                target = Target = #'v1_0.target'{address = {utf8, ?MANAGEMENT_NODE_ADDRESS}},
               } = Attach, State) ->
%% Friendlier error returned here.
%% What about other error conditions, like source defined, but target isn't?

[michaelklishin]

@lukebakken sure, why not. I assume amqp:not-found would be a good candidate.

[ansd]

@lukebakken it's the first time we see such a report. So, it's uncommon. That said, feel free to return a friendlier error.

[lukebakken]

Roger that. This seems to be the extent of pre-defined error conditions:

https://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-transport-v1.0-os.html#type-amqp-error