Cannot read property 'split' of undefined

[pelargir]

2.1.0 is tagged as pre-release so I assume it's not production-ready yet. We attempted to upgrade and immediately began getting these JS errors which are not present in the prior version:

[tresf]

Can you please provide the steps necessary to reproduce these errors?

• We'll need exact versions of QZ Tray and qz-tray.js (or we'll assume 2.1.0)
• We'll need code snippets to reproduce the problem

[pelargir]

QZ Tray v2.0.11-1
qz-tray.js 2.1.0

I haven't isolated the code that's causing the problem yet, but will post when I do.

[tresf]

@pelargir thanks. It's probably an overlooked entry in our compatible: function. We'd be happy to patch it once it's identified.

[tresf]

I haven't isolated the code that's causing the problem yet, but will post when I do.

@pelargir checking in to see if you can provide some sample code, we'd love to fix this. If we don't see the code in another week or so, we'll close this out, but we'd happily re-open it when the code is provided.

[pelargir]

Closing for now. I definitely won't be able to provide anything within a week.

[pelargir]

I've tracked the problem down to qz-tray.js on line 650:

compatible: function(printData) {
  var semver = _qz.websocket.connection.version.split(/[.-]/g);
  ...

The split method is being called on _qz.websocket.connection.version which is null. Here's a stack trace from the browser console:

qz-tray.js:705 Uncaught (in promise) TypeError: Cannot read property 'split' of undefined
    at Object.compatible (qz-tray.js:705)
    at Object.print (qz-tray.js:1283)
    at sendPrintJob (cozy-printer.js:68)

Any idea why the version would be null?

[tresf]

That should only be null if you're not connected (the value is filled on successful connection).

[tresf]

We did see this error for some customers and it was caused by a behavior change in the WebSocket as described here: #524

That fix was Java related, as the WebSocket would throw an unrecoverable error with certain browsers (Mostly Microsoft Edge), but that should be fixed with 2.1.0 proper.

[tresf]

Closing as fixed for now, since we can't reproduce and all previous errors were fixed in code. Please request a re-open if steps to reproduce can be provided.