don't complain about overwriting files IF in test mode

Author: sjanssen2

qiita_pet/handlers/cloud_handlers/file_transfer_handlers.py

@@ -92,7 +92,9 @@ def post(self):
                     filepath = filepath[len(os.sep):]
                 filepath = os.path.abspath(os.path.join(basedatadir, filepath))
 
-                if os.path.exists(filepath):
+                # prevent overwriting existing files, except in test mode
+                if os.path.exists(filepath) and \
+                   (not qiita_config.test_environment):
                     raise HTTPError(403, reason=(
                         "The requested file is already "
                         "present in Qiita's BASE_DATA_DIR!"))

qiita_pet/handlers/cloud_handlers/tests/test_file_transfer_handlers.py

@@ -5,6 +5,7 @@
 
 from qiita_db.handlers.tests.oauthbase import OauthTestingBase
 import qiita_db as qdb
+from qiita_core.qiita_settings import qiita_config
 
 
 class FetchFileFromCentralHandlerTests(OauthTestingBase):
@@ -70,7 +71,11 @@ def test_post(self):
 
         # check if error is raised, if file already exists
         with open(fp_source, 'rb') as fh:
+            # we need to let qiita thinks for this test, to NOT be in test mode
+            oldval = qiita_config.test_environment
+            qiita_config.test_environment = False
             obs = self.post_authed(endpoint, files={'bar/': fh})
+            qiita_config.test_environment = oldval
             self.assertIn("already present in Qiita's BASE_DATA_DIR!",
                           obs.reason)