add target and fix errors

Summary:
Add a buck target for `gloo/transport/uv` to prevent CodeMod from deleting this stack.

Also fix compile warnings that turn into errors with the code:
1. Remove unused variables or make use of unused variables.
2. Rename `struct` to `class`.
3. Prevent "declaration shadows a local variable".
4. Use manual to make linter happy

Reviewed By: fduwjj

Differential Revision: D65232668

fbshipit-source-id: a5156ba7a34eb84e5d09dd248df30f2a3f474426

Author: c-p-i-o

gloo/transport/uv/address.h

@@ -9,7 +9,7 @@
 #pragma once
 
 #ifdef _WIN32
-#include "gloo/common/win.h"
+#include "gloo/common/win.h" // @manual
 #else
 #include <sys/socket.h>
 #endif

gloo/transport/uv/common.h

@@ -10,7 +10,7 @@
 
 #include <stdio.h>
 
-#include <uv.h>
+#include <uv.h> // @manual
 
 #define UV_CHECK(rv, prefix)  \
   {                           \

gloo/transport/uv/device.cc

@@ -14,13 +14,13 @@
 #include <iostream>
 #include <sstream>
 
-#include <uv.h>
+#include <uv.h> // @manual
 
 #include <gloo/common/error.h>
 #ifndef _WIN32
 #include <gloo/common/linux.h>
 #else
-#include <gloo/common/win.h>
+#include <gloo/common/win.h> // @manual
 #endif
 #include <gloo/common/logging.h>
 #include <gloo/transport/uv/common.h>
@@ -180,8 +180,6 @@ std::shared_ptr<transport::Device> CreateDevice(struct attr attr) {
 }
 
 Device::Device(const struct attr& attr) : attr_(attr) {
-  int rv;
-
   loop_ = libuv::Loop::create();
 
   // Use async handle to trigger the event loop to
@@ -195,7 +193,7 @@ Device::Device(const struct attr& attr) : attr_(attr) {
   // Initialize server handle and wait for incoming connections.
   listener_ = loop_->resource<libuv::TCP>();
   listener_->on<libuv::ErrorEvent>(
-      [this](const libuv::ErrorEvent& event, const libuv::TCP&) {
+      [](const libuv::ErrorEvent& event, const libuv::TCP&) {
         // Nothing we can do about errors on the listener socket...
         GLOO_ENFORCE(!event, "Error on listener socket: ", event.what());
       });
@@ -261,16 +259,16 @@ void Device::connect(
   if (family == AF_INET) {
     const struct sockaddr_in* sa = (struct sockaddr_in*)&ss1;
     const struct sockaddr_in* sb = (struct sockaddr_in*)&ss2;
-    const auto addrlen = sizeof(struct sockaddr_in);
-    rv = memcmp(&sa->sin_addr, &sb->sin_addr, sizeof(struct in_addr));
+    const auto addrlen = sizeof(struct in_addr);
+    rv = memcmp(&sa->sin_addr, &sb->sin_addr, addrlen);
     if (rv == 0) {
       rv = sa->sin_port - sb->sin_port;
     }
   } else if (family == AF_INET6) {
     const struct sockaddr_in6* sa = (struct sockaddr_in6*)&ss1;
     const struct sockaddr_in6* sb = (struct sockaddr_in6*)&ss2;
-    const auto addrlen = sizeof(struct sockaddr_in6);
-    rv = memcmp(&sa->sin6_addr, &sb->sin6_addr, sizeof(struct in6_addr));
+    const auto addrlen = sizeof(struct in6_addr);
+    rv = memcmp(&sa->sin6_addr, &sb->sin6_addr, addrlen);
     if (rv == 0) {
       rv = sa->sin6_port - sb->sin6_port;
     }

gloo/transport/uv/libuv.h

@@ -33,7 +33,7 @@
 #include <utility>
 #include <vector>
 
-#include <uv.h>
+#include <uv.h> // @manual
 
 #define UV_ASSERT(rv, prefix) \
   {                           \
@@ -65,7 +65,7 @@ struct BaseHandle {};
 struct BaseRequest {};
 
 // Event type for errors.
-struct ErrorEvent {
+class ErrorEvent {
  public:
   explicit ErrorEvent(int error) : error_(error) {}
 
@@ -326,7 +326,7 @@ class Resource : public Emitter<T>, public std::enable_shared_from_this<T> {
   std::shared_ptr<T> leak_;
 };
 
-struct CloseEvent {};
+class CloseEvent {};
 
 template <typename T, typename U>
 class Handle : public Resource<T, U>, public BaseHandle {
@@ -440,11 +440,11 @@ class Timer : public Handle<Timer, uv_timer_t> {
   }
 };
 
-struct EndEvent {};
+class EndEvent {};
 
-struct ListenEvent {};
+class ListenEvent {};
 
-struct ConnectEvent {};
+class ConnectEvent {};
 
 class ReadEvent {
  public:
@@ -466,7 +466,7 @@ class ReadEvent {
   }
 };
 
-struct WriteEvent {};
+class WriteEvent {};
 
 namespace detail {
 

gloo/transport/uv/pair.cc

@@ -325,7 +325,7 @@ void Pair::onNotifyRecvReady(const Op& op) {
   if (it != localPendingSend_.end()) {
     auto& queue = it->second;
     GLOO_ENFORCE(!queue.empty());
-    auto op = std::move(queue.front());
+    auto nextOp = std::move(queue.front());
 
     // Remove operation from queue, and potentially remove map entry
     // for this tag.
@@ -334,9 +334,9 @@ void Pair::onNotifyRecvReady(const Op& op) {
       localPendingSend_.erase(it);
     }
 
-    auto buf = NonOwningPtr<UnboundBuffer>(op.buf);
+    auto buf = NonOwningPtr<UnboundBuffer>(nextOp.buf);
     GLOO_ENFORCE(buf, "Cannot lock pointer to unbound buffer");
-    sendUnboundBuffer(tag, std::move(buf), op.offset, op.length);
+    sendUnboundBuffer(tag, std::move(buf), nextOp.offset, nextOp.length);
     return;
   }