Skip to content

Commit eeb8667

Browse files
aobo-yfacebook-github-bot
authored andcommitted
Clean install_via_conda (#1097)
Summary: Circle CI job `test_conda` is failing because of some missing dependencies, like ``` E ImportError: libtiff.so.5: cannot open shared object file: No such file or directory ``` The cause is that when we install `nodejs` through conda, it will upgrade some packages, like ``` > conda install -y --no-channel-priority -c conda-forge nodejs=14 ... libtiff 4.3.0-hf544144_1 --> 4.5.0-h82bc61c_0 ``` The newer version is not be compatible with some python packages. Downgrade those incompatible packages will fix the issue. But I made this PR to just drop the installations of `nodejs` and `yarn` (and some other unused packages like `mypy` `flake8`). Also stop building `captum-insight` I feel `nodejs` & `yarn` are used for building the website and Insight's frontend. However, this script is only used in for CircleCI's conda testing, which does not execute anything related to Insight frontend or build website, so it safe to remove them. (I am not sure why we include them in the 1st place. Let me know if I missed some use cases of this script) Pull Request resolved: #1097 Reviewed By: vivekmig Differential Revision: D42201597 Pulled By: aobo-y fbshipit-source-id: a57a13a76176ffa47e5728d6359410c2f599ba24
1 parent 761a219 commit eeb8667

File tree

1 file changed

+4
-14
lines changed

1 file changed

+4
-14
lines changed

scripts/install_via_conda.sh

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -39,18 +39,8 @@ else
3939
fi
4040

4141
# install other deps
42-
# conda install -y numpy sphinx pytest flake8 ipywidgets ipython scikit-learn parameterized
43-
# conda install -y -c conda-forge matplotlib pytest-cov sphinx-autodoc-typehints mypy flask flask-compress
44-
conda install -y pytest flake8 ipywidgets ipython scikit-learn parameterized
45-
conda install -y -c conda-forge matplotlib pytest-cov mypy flask flask-compress
42+
conda install -y pytest ipywidgets ipython scikit-learn parameterized
43+
conda install -y -c conda-forge matplotlib pytest-cov flask flask-compress
4644

47-
# deps not available in conda
48-
# pip install sphinxcontrib-katex
49-
50-
# install node/yarn for insights build
51-
conda install -y -c conda-forge yarn
52-
# nodejs should be last, otherwise other conda packages will downgrade node
53-
conda install -y --no-channel-priority -c conda-forge nodejs=14
54-
55-
# build insights and install captum
56-
BUILD_INSIGHTS=1 python setup.py develop
45+
# install captum
46+
python setup.py develop

0 commit comments

Comments
 (0)