-
Notifications
You must be signed in to change notification settings - Fork 351
Open
Milestone
Description
Enhancement request:
TL;DR: @DigiDuncan pointed out we can't really load .ogg through arcade
What should be added/changed?
- Add a way to pass a decoder supported by pyglet's
media.load
function - (Optional / risky) Smart and helpful
pyogg
/PyOggDecoder
warnings
What would passing in a decoder would it help with?
Improve arcade user experience by allowing sound loading to:
- take specific decoders such as pyglet's
PyOggDecoder
- avoid subclassing
Sound
as in Charm's current code - without having to file tickets for new formats (example: QOA)
Changes needed:
- Add a
decoder
keyword argument toarcade.sound.Sound.__init__
Add a tempUse the existingDecoder
protocol to annotate it before upstreaming matching pyglet's codecsMediaDecoder
type- Document the change
- Update the sound page in the programming guide
Follow-up Work
- Add an example
- Make upstream pyglet PRs to help with pyglet needs a full docstring review and cleanup pyglet/pyglet#1084:
Define aDecoder
Protocol
type matching pyglet's pyglet's codecs- Add argument and return annotations to the codecs
Metadata
Metadata
Assignees
Labels
No labels