Skip to content

Feature request: merge workspace build section to apply to all packages #1311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
noisyscanner opened this issue Jan 20, 2025 · 2 comments · May be fixed by #1316
Open

Feature request: merge workspace build section to apply to all packages #1311

noisyscanner opened this issue Jan 20, 2025 · 2 comments · May be fixed by #1316
Labels
feature help wanted

Comments

@noisyscanner
Copy link

We would like to set censorProjectWarnings for all packages in our monorepo (and probably strict: true at a later date as well)
As far as I can see this isn't currently possible? We can only set censorLibraryWarnings in workspace.buildOpts.

What about having something like a "base" package section in the workspace spago.yaml that could specify things like this that would apply to all packages by default, like build.strict and build.censorProjectWarnings?

Sub-packages could always override it later in their own package spago.yaml files..
@f-f
Copy link
Member

f-f commented Jan 22, 2025

@noisyscanner I think something like this would make sense. I'll mark it as up for grabs since it should be pretty straightforward to implement

@noisyscanner
Copy link
Author

Am working on this atm, should have something pretty soon

@noisyscanner noisyscanner linked a pull request Jan 26, 2025 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

censorProjectWarnings in monorepo workspace spago.yaml OxfordAbstracts/spago
2 participants
@noisyscanner @f-f