Skip to content

message is ignored if method throws HTTPError #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
yanok opened this issue Oct 27, 2017 · 2 comments
Open

message is ignored if method throws HTTPError #7

yanok opened this issue Oct 27, 2017 · 2 comments

Comments

@yanok
Copy link

yanok commented Oct 27, 2017

If some method decides to throw an HTTPError the provided message is simply ignored.
@owickstrom
Copy link
Collaborator

Do you mean this message: https://github.com/owickstrom/purescript-hypertrout/blob/master/src/Hyper/Trout/Router.purs#L352 ? Could you provide a minimal example to reproduce the problem?

@yanok
Copy link
Author

yanok commented Oct 27, 2017

No, I mean when method hander returns Left RoutingError, the message part the error is ignored. Here: https://github.com/owickstrom/purescript-hypertrout/blob/fd59265f081795fd010abca43bdc2990e186b478/src/Hyper/Trout/Router.purs#L246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yanok @owickstrom