Skip to content

1.1.5 - warning: System.stacktrace/0 is deprecated, use __STACKTRACE__ instead #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dylan-chong opened this issue Jan 4, 2021 · 1 comment

Comments

@dylan-chong
Copy link

dylan-chong commented Jan 4, 2021

use Prometheus.PlugPipelineInstrumenter

The code above triggers the following warning:

warning: System.stacktrace/0 is deprecated, use __STACKTRACE__ instead

on Elixir 1.11[.2].

This is a problem because we use mix compile --warnings-as-errors in our CI to prevent developer mistakes/warnings seeping into master, which means our CI builds fail because of this warning.

Looks like you can also mark the macro code as generated to supress warnings https://github.com/elixir-lang/elixir/blob/b889975c5574d9edd679ecf55c6707e3eb1f51d1/lib/ex_unit/lib/ex_unit/assertions.ex#L710

@dylan-chong
Copy link
Author

Ok so this looks fixed in Prometheus prometheus-erl/prometheus.ex@dea38d0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant