fix lint

csouchet · csouchet · commit 15666bace7de · 2025-02-21T17:33:54.000+01:00
diff --git a/packages/addons/src/bpmn-elements.ts b/packages/addons/src/bpmn-elements.ts
@@ -106,7 +106,7 @@ export class BpmnElementsIdentifier {
   }
 
   isBpmnArtifact(elementId: string): boolean {
-    return this.isInCategory(ShapeUtil.isBpmnArtifact, elementId);
+    return this.isInCategory(ShapeUtility.isBpmnArtifact, elementId);
   }
 
   isGateway(elementId: string): boolean {
@@ -128,13 +128,13 @@ export class BpmnElementsIdentifier {
   }
 }
 
-export class ShapeUtil extends BaseShapeUtility {
+export class ShapeUtility extends BaseShapeUtility {
   static isBpmnArtifact(kind: ShapeBpmnElementKind | string): boolean {
     return kind === ShapeBpmnElementKind.GROUP || kind === ShapeBpmnElementKind.TEXT_ANNOTATION;
   }
 
   static isFlowNode(kind: ShapeBpmnElementKind | string): boolean {
     // there is currently a bug in bpmn-visualization (at least in version 0.44.0). It includes artifacts in flowNodeKinds.
-    return ShapeUtil.flowNodeKinds().includes(kind as ShapeBpmnElementKind) && !ShapeUtil.isBpmnArtifact(kind);
+    return ShapeUtility.flowNodeKinds().includes(kind as ShapeBpmnElementKind) && !ShapeUtility.isBpmnArtifact(kind);
   }
 }
diff --git a/packages/addons/test/shared/bv-utilities.ts b/packages/addons/test/shared/bv-utilities.ts
diff --git a/packages/addons/test/shared/dom-utilities.ts b/packages/addons/test/shared/dom-utilities.ts
diff --git a/packages/addons/test/shared/io-utilities.ts b/packages/addons/test/shared/io-utilities.ts
diff --git a/packages/addons/test/spec/bpmn-elements.test.ts b/packages/addons/test/spec/bpmn-elements.test.ts
@@ -19,10 +19,10 @@ import type { ShapeBpmnSemantic } from 'bpmn-visualization';
 import { describe, expect, test } from '@jest/globals';
 import { FlowKind, ShapeBpmnElementKind, ShapeBpmnEventDefinitionKind, ShapeUtil as BaseShapeUtility } from 'bpmn-visualization';
 
-import { BpmnElementsIdentifier, BpmnElementsSearcher, BpmnVisualization, ShapeUtil as ShapeUtility } from '../../src/index.js';
-import { createNewBpmnVisualizationWithoutContainer } from '../shared/bv-utils.js';
-import { insertBpmnContainerWithoutId } from '../shared/dom-utils.js';
-import { readFileSync } from '../shared/io-utils.js';
+import { BpmnElementsIdentifier, BpmnElementsSearcher, BpmnVisualization, ShapeUtility } from '../../src/index.js';
+import { createNewBpmnVisualizationWithoutContainer } from '../shared/bv-utilities.js';
+import { insertBpmnContainerWithoutId } from '../shared/dom-utilities.js';
+import { readFileSync } from '../shared/io-utilities.js';
 
 describe('Find elements by providing names', () => {
   const bpmnVisualization = new BpmnVisualization({ container: insertBpmnContainerWithoutId() });
diff --git a/packages/addons/test/spec/paths.test.ts b/packages/addons/test/spec/paths.test.ts
@@ -20,8 +20,8 @@ import { beforeEach, describe, expect, test } from '@jest/globals';
 import { FlowKind, ShapeBpmnElementKind, ShapeBpmnEventDefinitionKind } from 'bpmn-visualization';
 
 import { CasePathResolver, PathResolver } from '../../src/index.js';
-import { createNewBpmnVisualizationWithoutContainer } from '../shared/bv-utils.js';
-import { readFileSync } from '../shared/io-utils.js';
+import { createNewBpmnVisualizationWithoutContainer } from '../shared/bv-utilities.js';
+import { readFileSync } from '../shared/io-utilities.js';
 
 const bpmnVisualization = createNewBpmnVisualizationWithoutContainer();
 const ensureElementsExistInModel = (ids: string[]): void => {
diff --git a/packages/addons/test/spec/plugins-support.test.ts b/packages/addons/test/spec/plugins-support.test.ts
@@ -20,7 +20,7 @@ import type { GlobalOptions } from 'bpmn-visualization';
 import { describe, expect, test } from '@jest/globals';
 
 import { BpmnVisualization } from '../../src/index.js';
-import { createNewBpmnVisualizationWithoutContainer } from '../shared/bv-utils.js';
+import { createNewBpmnVisualizationWithoutContainer } from '../shared/bv-utilities.js';
 
 test('No error when no plugin is defined', () => {
   const bpmnVisualization = createNewBpmnVisualizationWithoutContainer();
diff --git a/packages/addons/test/spec/plugins/css-classes.test.ts b/packages/addons/test/spec/plugins/css-classes.test.ts
@@ -18,7 +18,7 @@ import { beforeEach, describe, expect, jest, test } from '@jest/globals';
 import { BpmnElementsRegistry } from 'bpmn-visualization';
 
 import { BpmnVisualization, CssClassesPlugin } from '../../../src/index.js';
-import { insertBpmnContainerWithoutId } from '../../shared/dom-utils.js';
+import { insertBpmnContainerWithoutId } from '../../shared/dom-utilities.js';
 
 // jest mock configuration
 const mockBvAddCssClassesByIds = jest.spyOn(BpmnElementsRegistry.prototype, 'addCssClasses');
diff --git a/packages/addons/test/spec/plugins/elements.test.ts b/packages/addons/test/spec/plugins/elements.test.ts
@@ -18,8 +18,8 @@ import { describe, expect, test } from '@jest/globals';
 import { ShapeBpmnElementKind, ShapeBpmnEventDefinitionKind, type ShapeBpmnSemantic } from 'bpmn-visualization';
 
 import { BpmnVisualization, ElementsPlugin } from '../../../src/index.js';
-import { insertBpmnContainerWithoutId } from '../../shared/dom-utils.js';
-import { readFileSync } from '../../shared/io-utils.js';
+import { insertBpmnContainerWithoutId } from '../../shared/dom-utilities.js';
+import { readFileSync } from '../../shared/io-utilities.js';
 
 // The actual implementation is in `bpmn-visualization`. Here, we only validate that the `bpmn-visualization` code is called.
 describe('Check ElementsPlugin methods', () => {
diff --git a/packages/addons/test/spec/plugins/overlays.test.ts b/packages/addons/test/spec/plugins/overlays.test.ts
@@ -15,13 +15,14 @@ limitations under the License.
 */
 
 import type { Overlay } from 'bpmn-visualization';
+// eslint-disable-next-line n/no-extraneous-import
 import type { mxGraph, mxGraphModel } from 'mxgraph';
 
 import { beforeEach, describe, expect, test } from '@jest/globals';
 
 import { BpmnVisualization, OverlaysPlugin } from '../../../src/index.js';
-import { insertBpmnContainerWithoutId } from '../../shared/dom-utils.js';
-import { readFileSync } from '../../shared/io-utils.js';
+import { insertBpmnContainerWithoutId } from '../../shared/dom-utilities.js';
+import { readFileSync } from '../../shared/io-utilities.js';
 
 /**
  * Information taken from bpmn-visualization QuerySelectors
@@ -183,7 +184,6 @@ class OverlaysExpectation {
     this.model = bpmnVisualization.graph.model;
   }
 
-  /* eslint-disable jest/no-standalone-expect -- util code, including expect calls */
   expectNoOverlay(bpmnId: string): void {
     expect(this.getOverlays(bpmnId)).toHaveLength(0);
   }
@@ -200,7 +200,6 @@ class OverlaysExpectation {
     expect(overlays).toHaveLength(labels.length);
     expect(overlays.map(overlay => overlay.label)).toEqual(labels);
   }
-  /* eslint-enable jest/no-standalone-expect */
 }
 
 // The real type is "class MxGraphCustomOverlay extends mxgraph.mxCellOverlay" but it is not part of the API so create a convenient matching type here
diff --git a/packages/addons/test/spec/plugins/style.test.ts b/packages/addons/test/spec/plugins/style.test.ts
@@ -18,8 +18,8 @@ import { beforeEach, describe, expect, jest, test } from '@jest/globals';
 import { BpmnElementsRegistry } from 'bpmn-visualization';
 
 import { BpmnVisualization, StyleByNamePlugin, StylePlugin } from '../../../src/index.js';
-import { insertBpmnContainerWithoutId } from '../../shared/dom-utils.js';
-import { readFileSync } from '../../shared/io-utils.js';
+import { insertBpmnContainerWithoutId } from '../../shared/dom-utilities.js';
+import { readFileSync } from '../../shared/io-utilities.js';
 
 // jest mock configuration
 const mockBvResetStyleByIds = jest.spyOn(BpmnElementsRegistry.prototype, 'resetStyle');
diff --git a/packages/check-ts-support/src/index.ts b/packages/check-ts-support/src/index.ts
@@ -15,6 +15,7 @@ limitations under the License.
 */
 
 import { BpmnElementsIdentifier, PathResolver } from '@process-analytics/bpmn-visualization-addons';
+// eslint-disable-next-line n/no-extraneous-import
 import { BpmnVisualization } from 'bpmn-visualization';
 
 // bpmn-visualization
diff --git a/packages/check-ts-support/tsconfig.json b/packages/check-ts-support/tsconfig.json
@@ -10,6 +10,9 @@
     "strict": true,
     "noEmit": true,
     "skipLibCheck": false,
+    "paths": {
+      "@process-analytics/bpmn-visualization-addons": ["../addons/dist/index.d.ts"]
+    }
   },
   "include": [
     "src/**/*"
diff --git a/packages/demo/src/shared/diagrams.ts b/packages/demo/src/shared/diagrams.ts
@@ -20,6 +20,7 @@ limitations under the License.
 import diagramUrl from '../assets/bpmn/EC-purchase-orders-collapsed.xml?url';
 
 export async function fetchDiagram(): Promise<string> {
+  // eslint-disable-next-line n/no-unsupported-features/node-builtins
   const response = await fetch(diagramUrl);
   return await response.text();
 }
diff --git a/packages/demo/tsconfig.json b/packages/demo/tsconfig.json
@@ -13,7 +13,10 @@
     "noUnusedLocals": true,
     "noUnusedParameters": true,
     "noImplicitReturns": true,
-    "skipLibCheck": true
+    "skipLibCheck": true,
+    "paths": {
+      "@process-analytics/bpmn-visualization-addons": ["../addons/dist/index.d.ts"]
+    }
   },
   "include": ["src"]
 }

Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,7 @@ export class BpmnElementsIdentifier {`
`106`	`106`	`}`
`107`	`107`
`108`	`108`	`isBpmnArtifact(elementId: string): boolean {`
`109`		`- return this.isInCategory(ShapeUtil.isBpmnArtifact, elementId);`
	`109`	`+ return this.isInCategory(ShapeUtility.isBpmnArtifact, elementId);`
`110`	`110`	`}`
`111`	`111`
`112`	`112`	`isGateway(elementId: string): boolean {`
`@@ -128,13 +128,13 @@ export class BpmnElementsIdentifier {`
`128`	`128`	`}`
`129`	`129`	`}`
`130`	`130`
`131`		`-export class ShapeUtil extends BaseShapeUtility {`
	`131`	`+export class ShapeUtility extends BaseShapeUtility {`
`132`	`132`	`static isBpmnArtifact(kind: ShapeBpmnElementKind \| string): boolean {`
`133`	`133`	`return kind === ShapeBpmnElementKind.GROUP \|\| kind === ShapeBpmnElementKind.TEXT_ANNOTATION;`
`134`	`134`	`}`
`135`	`135`
`136`	`136`	`static isFlowNode(kind: ShapeBpmnElementKind \| string): boolean {`
`137`	`137`	`// there is currently a bug in bpmn-visualization (at least in version 0.44.0). It includes artifacts in flowNodeKinds.`
`138`		`- return ShapeUtil.flowNodeKinds().includes(kind as ShapeBpmnElementKind) && !ShapeUtil.isBpmnArtifact(kind);`
	`138`	`+ return ShapeUtility.flowNodeKinds().includes(kind as ShapeBpmnElementKind) && !ShapeUtility.isBpmnArtifact(kind);`
`139`	`139`	`}`
`140`	`140`	`}`