Add call to set Serial options to prevent CR to CRLF conversion (#311)

diyelectromusic · probonopd · web-flow · commit dcbd04c831b0 · 2022-08-25T19:58:25.000+02:00
Co-authored-by: probonopd &lt;probonopd@users.noreply.github.com&gt;
diff --git a/src/serialmididevice.cpp b/src/serialmididevice.cpp
@@ -49,7 +49,12 @@ CSerialMIDIDevice::~CSerialMIDIDevice (void)
 boolean CSerialMIDIDevice::Initialize (void)
 {
 	assert (m_pConfig);
-	return m_Serial.Initialize (m_pConfig->GetMIDIBaudRate ());
+	boolean res = m_Serial.Initialize (m_pConfig->GetMIDIBaudRate ());
+	unsigned ser_options = m_Serial.GetOptions();
+	// Ensure CR->CRLF translation is disabled for MIDI links
+	ser_options &= ~(SERIAL_OPTION_ONLCR);
+	m_Serial.SetOptions(ser_options);
+	return res;
 }
 
 void CSerialMIDIDevice::Process (void)

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,12 @@ CSerialMIDIDevice::~CSerialMIDIDevice (void)`
`49`	`49`	`boolean CSerialMIDIDevice::Initialize (void)`
`50`	`50`	`{`
`51`	`51`	`assert (m_pConfig);`
`52`		`- return m_Serial.Initialize (m_pConfig->GetMIDIBaudRate ());`
	`52`	`+ boolean res = m_Serial.Initialize (m_pConfig->GetMIDIBaudRate ());`
	`53`	`+ unsigned ser_options = m_Serial.GetOptions();`
	`54`	`+ // Ensure CR->CRLF translation is disabled for MIDI links`
	`55`	`+ ser_options &= ~(SERIAL_OPTION_ONLCR);`
	`56`	`+ m_Serial.SetOptions(ser_options);`
	`57`	`+ return res;`
`53`	`58`	`}`
`54`	`59`
`55`	`60`	`void CSerialMIDIDevice::Process (void)`