Skip to content

Commit c3122b2

Browse files
committed
Address issues on Docker PoS Mainnet
1 parent d31a7ec commit c3122b2

File tree

3 files changed

+45
-24
lines changed

3 files changed

+45
-24
lines changed

packages/page-staking/src/Overview/SummaryNominators.tsx

Lines changed: 24 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import React from 'react';
55

66
import { Card, CardSummary, MarkWarning, SummaryBox } from '@polkadot/react-components';
7+
import { useApi } from '@polkadot/react-hooks';
78
import { FormatBalance } from '@polkadot/react-query';
89
import { formatNumber } from '@polkadot/util';
910

@@ -23,6 +24,12 @@ function SummaryNominators ({ targets: { maxNominatorsCount,
2324
nominatorMinActiveThreshold } }: Props) {
2425
const { t } = useTranslation();
2526

27+
const { api } = useApi();
28+
29+
const maxElectingVotersDefined = !!api.consts.electionProviderMultiPhase?.maxElectingVoters;
30+
const maxNominatorDefined = !!api.query.staking.maxNominatorsCount;
31+
const minNominatorBondDefined = !!api.query.staking.minNominatorBond;
32+
2633
return (
2734
<>
2835
<Card withBottomMargin>
@@ -33,21 +40,23 @@ function SummaryNominators ({ targets: { maxNominatorsCount,
3340
help={t<string>('Maximum number of nominator intentions.')}
3441
label={t<string>('maximum')}
3542
>
36-
<SpinnerWrap check={maxNominatorsCount}>
37-
{formatNumber(maxNominatorsCount?.toNumber())}
38-
</SpinnerWrap>
43+
{maxNominatorDefined
44+
? <SpinnerWrap check={maxNominatorsCount}>
45+
{formatNumber(maxNominatorsCount?.toNumber())}
46+
</SpinnerWrap>
47+
: '-'}
3948
</CardSummary>
4049
</Section>
4150
<Section>
4251
<CardSummary
4352
help={t<string>('Number of electing nominators.')}
4453
label={t<string>('electing')}
4554
>
46-
{nominatorMaxElectingCount === null
47-
? <>-</>
48-
: <SpinnerWrap check={nominatorMaxElectingCount}>
55+
{maxElectingVotersDefined
56+
? <SpinnerWrap check={nominatorMaxElectingCount}>
4957
{formatNumber(nominatorMaxElectingCount)}
50-
</SpinnerWrap>}
58+
</SpinnerWrap>
59+
: '-'}
5160
</CardSummary>
5261
</Section>
5362
<Section>
@@ -67,12 +76,14 @@ function SummaryNominators ({ targets: { maxNominatorsCount,
6776
help={t<string>('Threshold stake to intend nomination.')}
6877
label={t<string>('intention thrs')}
6978
>
70-
<SpinnerWrap check={minNominatorBond}>
71-
<FormatBalance
72-
value={minNominatorBond}
73-
withSi
74-
/>
75-
</SpinnerWrap>
79+
{minNominatorBondDefined
80+
? <SpinnerWrap check={minNominatorBond}>
81+
<FormatBalance
82+
value={minNominatorBond}
83+
withSi
84+
/>
85+
</SpinnerWrap>
86+
: '-'}
7687
</CardSummary>
7788
</Section>
7889
<Section>

packages/page-staking/src/Overview/SummaryValidators.tsx

Lines changed: 18 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import React from 'react';
55

66
import { Card, CardSummary, SummaryBox } from '@polkadot/react-components';
7+
import { useApi } from '@polkadot/react-hooks';
78
import { FormatBalance } from '@polkadot/react-query';
89
import { formatNumber } from '@polkadot/util';
910

@@ -24,6 +25,10 @@ function SummaryValidators ({ targets:
2425
validatorMinActiveThreshold,
2526
waitingIds } }: Props) {
2627
const { t } = useTranslation();
28+
const { api } = useApi();
29+
30+
const maxValidatorDefined = !!api.query.staking.maxValidatorsCount;
31+
const minValidatorBondDefined = !!api.query.staking.minValidatorBond;
2732

2833
return (
2934
<Card withBottomMargin>
@@ -34,9 +39,11 @@ function SummaryValidators ({ targets:
3439
help={t<string>('Maximum number of validator intentions.')}
3540
label={t<string>('max intention')}
3641
>
37-
<SpinnerWrap check={maxValidatorsCount}>
38-
{maxValidatorsCount?.toNumber()}
39-
</SpinnerWrap>
42+
{maxValidatorDefined
43+
? <SpinnerWrap check={maxValidatorsCount}>
44+
{maxValidatorsCount?.toNumber()}
45+
</SpinnerWrap>
46+
: '-'}
4047
</CardSummary>
4148
</Section>
4249
<Section>
@@ -66,12 +73,14 @@ function SummaryValidators ({ targets:
6673
help={t<string>('Threshold stake among intended validators.')}
6774
label={t<string>('intention thrs')}
6875
>
69-
<SpinnerWrap check={minValidatorBond}>
70-
<FormatBalance
71-
value={minValidatorBond}
72-
withSi
73-
/>
74-
</SpinnerWrap>
76+
{minValidatorBondDefined
77+
? <SpinnerWrap check={minValidatorBond}>
78+
<FormatBalance
79+
value={minValidatorBond}
80+
withSi
81+
/>
82+
</SpinnerWrap>
83+
: '-'}
7584
</CardSummary>
7685
</Section>
7786
<Section>

packages/page-staking/src/useSortedTargets.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -288,13 +288,14 @@ function useSortedTargetsImpl (favorites: string[], withLedger: boolean): Sorted
288288
api.query.staking.minValidatorBond,
289289
api.query.balances?.totalIssuance
290290
], OPT_MULTI);
291+
291292
const electedInfo = useCall<DeriveStakingElected>(api.derive.staking.electedInfo, [{ ...DEFAULT_FLAGS_ELECTED, withLedger }]);
292293
const waitingInfo = useCall<DeriveStakingWaiting>(api.derive.staking.waitingInfo, [{ ...DEFAULT_FLAGS_WAITING, withLedger }]);
293294
const lastEraInfo = useCall<LastEra>(api.derive.session.info, undefined, OPT_ERA);
294295
const [stakers, setStakers] = useState<[StorageKey<[u32, AccountId32]>, PalletStakingExposure][]>([]);
295296
const [stakersTotal, setStakersTotal] = useState<BN | undefined>();
296297
const [nominatorMinActiveThreshold, setNominatorMinActiveThreshold] = useState<string>('');
297-
const [nominatorMaxElectingCount, setNominatorMaxElectingCount] = useState<u32 | null>();
298+
const [nominatorMaxElectingCount, setNominatorMaxElectingCount] = useState<u32>();
298299
const [nominatorElectingCount, setNominatorElectingCount] = useState<number | undefined>();
299300
const [nominatorActiveCount, setNominatorActiveCount] = useState<number | undefined>();
300301
const [validatorActiveCount, setValidatorActiveCount] = useState<number | undefined>();
@@ -323,7 +324,7 @@ function useSortedTargetsImpl (favorites: string[], withLedger: boolean): Sorted
323324

324325
nominatorStakes.sort((a, b) => a[1].cmp(b[1]));
325326

326-
setNominatorMaxElectingCount(api.consts.electionProviderMultiPhase?.maxElectingVoters || null);
327+
setNominatorMaxElectingCount(api.consts.electionProviderMultiPhase?.maxElectingVoters);
327328

328329
setNominatorElectingCount(assignments.size);
329330
setNominatorActiveCount(assignments.size);

0 commit comments

Comments
 (0)