Crash invalid memory access on iOS 15,16 and 17 since 1.2.4

[Alex293]

Hi,

I'm hitting a crash while running tests on iOS 15,16 and 17 since 1.2.4. The error vary a bit version by version but seems to be always a bad memory access. A full reproducer with a test case is joined below.

@Test
func testCrash() async throws {
  reportIssue("")
}

is enough to reproduce though.

I haven't spent much time but I'm pretty sure it either the unsafe cast that doesn't work which would mean the symbol is not mangled the same between iOS 18 and below or maybe the isolation of the auto-closure ?

I'll try to investigate more but I afraid this is beyond my skills for now :)

All this is using the latest App Store Xcode Version 16.3 (16E140) with the provided toolchain.

CrashIssueReporting.zip

[mbrandonw]

Hi @Alex293, I'm still investigating this, but at the very least it seems that this crash only happens with an empty string. So these will all not crash:

@Test func foo() {
  reportIssue(" ")
  reportIssue("1")
  reportIssue(/*nil message*/)
}

Do you ever run into this crash when specify a non-empty message?

[mbrandonw]

Also, FWIW, this crash affects just plain Swift Testing:

import Testing
@Test func foo() {
  Issue.record("")  // 🛑
}

So it doesn't look like this is an issue with our library, but it is something we can workaround. I am going to convert this to a discussion for now and we can continue the conversation over there.

[Alex293]

Yeah I'm getting a crash in the tests of the app on iOS 16 with a message:

All tests for the app passed with iOS 17 indicating that I don't use empty issue messages. Also the scope seems to be limited to tests as we sometime get issue reports for missing withPerceptionTracking while developing.

The app tests are using the latest version of the lib as opposed to the linked project.

[mbrandonw]

Can you provide a repro project for that kind of crash? I just ran the reportIssue("hey") on iOS 16 and it seemed to run fine.

[Alex293]

Sure maybe it’s device dependent instead of os.

[Alex293]

This one crashes on iOS 16.0, tried with newly created sims on iPhone 8, 12 mini, 13 mini, full clean each times.
CrashIssueReporting 3.zip

[Alex293]

I have the same results using 1.5.2. 15.5 and 17.0 are ok so long the message is not empty, 18 always passes and 16 never passes. What a strange issue.

update: 16.4 passes ..

Anyway I agree it's not necessary to merge the non empty bug as it's not really an issue with the lib.
I'll use 17 and 18 to run my tests as it's not affecting production on 16.

I guess there is no point digging more as it's not under the lib control.