You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This might be of ease developing on local platforms without support, but these kinds of skipped tests also affect the CI, skipping the tests unknowingly if there are missing dependencies. As a matter of fact, tests using RocksDBStore were being skipped on the CI with linux-netcore jobs. (Fixed with #2156)
Thus, we would have to decide how we will deal with tests of this sort, whether it is problematic and we should have it fail as is if there are missing dependencies.
My two cents are to have them fail regardless, since they are not to be run in the first place if the dependencies are missing. It would be easier to detect if there's anything wrong on the CI.
discussion neededWe need to dicuss about thisci & cdRelated to CI & CD on Azure Pipelines & GitHub Actions
1 participant
Converted from issue
This discussion was converted from issue #2165 on August 17, 2022 05:55.
Heading
Bold
Italic
Quote
Code
Link
Numbered list
Unordered list
Task list
Attach files
Mention
Reference
Menu
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Currently, parts of test codes related to RocksDB are skipped if RocksDB is unavailable:
This might be of ease developing on local platforms without support, but these kinds of skipped tests also affect the CI, skipping the tests unknowingly if there are missing dependencies. As a matter of fact, tests using RocksDBStore were being skipped on the CI with
linux-netcorejobs. (Fixed with #2156)Thus, we would have to decide how we will deal with tests of this sort, whether it is problematic and we should have it fail as is if there are missing dependencies.
My two cents are to have them fail regardless, since they are not to be run in the first place if the dependencies are missing. It would be easier to detect if there's anything wrong on the CI.
Related: #974
Beta Was this translation helpful? Give feedback.
All reactions