Skip to content

ox as an optional peer dependency #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
carlosrsabreu opened this issue Apr 28, 2025 · 4 comments
Open

ox as an optional peer dependency #399

carlosrsabreu opened this issue Apr 28, 2025 · 4 comments

Comments

@carlosrsabreu
Copy link

carlosrsabreu commented Apr 28, 2025

When installing v0.2.43, I ran into a problem when building my project using pnpm:

Import trace for requested module:
../../node_modules/.pnpm/[email protected][email protected][email protected][email protected][email protected]_/node_modules/permissionless/_esm/accounts/index.js
../../node_modules/.pnpm/@[email protected]_@[email protected]_@[email protected]_@[email protected]__@types_424d5a67b0e25619433d3b7545479202/node_modules/@fourt/sdk/dist/index.js
./providers/UserProvider/index.tsx
./app/layout.tsx

../../node_modules/.pnpm/[email protected][email protected][email protected][email protected][email protected]_/node_modules/permissionless/_esm/accounts/kernel/utils/signMessage.js
Module not found: Can't resolve 'ox'

Then, I suspect the problem lies in considering the ox as an optional peer dependency, which is why it is not being installed. Can anyone explain to me why ox is an optional peer dependency?

"peerDependenciesMeta": {
"ox": {
"optional": true
}
}

I resolved this issue by installing the ox package in version 0.6.7 in my application, and the build started working again.

@carlosrsabreu carlosrsabreu changed the title ox as an option peer dependency ox as an optional peer dependency Apr 28, 2025
@plusminushalf
Copy link
Member

ox is an optional peer dependency because not all smart accounts depends on it. You have to use ox only when using kernel smart account. Now that I think about it, maybe it is better to remove optional for now.

@plusminushalf
Copy link
Member

Will release a new version - #400

@carlosrsabreu
Copy link
Author

Got it, thank you!

@chaitanyapotti
Copy link

@plusminushalf Can you look at #401 as well. It solves a common peer dep issue when using latest viem with permissionless

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants