Improve memory limit test

Author: JoshuaBehrens

tests/set_memory_limit_001.phpt

@@ -13,20 +13,22 @@ if (getenv("SKIP_SLOW_TESTS")) {
 
 $JS = <<< EOT
 var jsfunc = function() {
-    var text = "abcdefghijklmnopqrstuvwyxz0123456789";
+    var text = "abcdefghijklmnopqrstuvwyxz0123456789"; // 36 bytes fits 277777 times in 10 MB
     var memory = "";
-    for (var i = 0; i < 100; ++i) {
-	for (var j = 0; j < 10000; ++j) {
+
+    // this should exceed the memory limit as it tries to generate 500_000 * 36 bytes = 18 MB
+    for (var i = 0; i < 50; ++i) {
+        for (var j = 0; j < 10_000; ++j) {
             memory += text;
-	}
-	sleep(0);
+        }
+        sleep(0);
     }
 };
 jsfunc;
 EOT;
 
 $v8 = new V8Js();
-$v8->setMemoryLimit(10000000);
+$v8->setMemoryLimit(10_000_000);
 
 $func = $v8->executeString($JS);
 var_dump($func);

tests/set_memory_limit_003.phpt

@@ -14,14 +14,8 @@ if (getenv("SKIP_SLOW_TESTS")) {
 $JS = <<< EOT
 var jsfunc = function() {
     PHP.imposeMemoryLimit();
-    var text = "abcdefghijklmnopqrstuvwyxz0123456789";
-    var memory = "";
-    for (var i = 0; i < 100; ++i) {
-	for (var j = 0; j < 10000; ++j) {
-            memory += text;
-	}
-	sleep(0);
-    }
+    // Allocate a single large string to deterministically exceed the limit
+    var memory = new Array(12 * 1024 * 1024).join("x"); // ~12MB
 };
 jsfunc;
 EOT;

tests/set_memory_limit_basic.phpt

@@ -11,14 +11,8 @@ if (getenv("SKIP_SLOW_TESTS")) {
 --FILE--
 <?php
 $JS = <<< EOT
-var text = "abcdefghijklmnopqrstuvwyxz0123456789";
-var memory = "";
-for (var i = 0; i < 100; ++i) {
-    for (var j = 0; j < 10000; ++j) {
-        memory += text;
-    }
-    sleep(0);
-}
+// Allocate a single large string to deterministically exceed the limit
+var memory = new Array(12 * 1024 * 1024).join("x"); // ~12 MB
 EOT;
 
 $v8 = new V8Js();