Fix build

Author: ondrejmirtes

src/Rules/Classes/ClassAttributesRule.php

@@ -32,25 +32,26 @@ public function getNodeType(): string
 
 	public function processNode(Node $node, Scope $scope): array
 	{
-		$classLikeNode = $node->getOriginalNode();
+		$classReflection = $node->getClassReflection();
+
+		if (count($classReflection->getNativeReflection()->getAttributes('Deprecated')) > 0) {
+			$typeName = strtolower($classReflection->getClassTypeDescription());
+			return [
+				RuleErrorBuilder::message(sprintf('Attribute class Deprecated cannot be used with %s %s.', $typeName, $classReflection->getDisplayName()))
+					->identifier(sprintf('%s.deprecatedAttribute', $typeName))
+					->nonIgnorable()
+					->build(),
+			];
+		}
 
+		$classLikeNode = $node->getOriginalNode();
 		$errors = $this->attributesCheck->check(
 			$scope,
 			$classLikeNode->attrGroups,
 			Attribute::TARGET_CLASS,
 			'class',
 		);
 
-		$classReflection = $node->getClassReflection();
-
-		if (count($classReflection->getNativeReflection()->getAttributes('Deprecated')) > 0) {
-			$typeName = strtolower($classReflection->getClassTypeDescription());
-			$errors[] = RuleErrorBuilder::message(sprintf('Attribute class Deprecated cannot be used with %s %s.', $typeName, $classReflection->getDisplayName()))
-				->identifier(sprintf('%s.deprecatedAttribute', $typeName))
-				->nonIgnorable()
-				->build();
-		}
-
 		if (
 			$classReflection->isReadOnly()
 			|| $classReflection->isEnum()

src/Rules/Traits/TraitAttributesRule.php

@@ -34,6 +34,17 @@ public function getNodeType(): string
 
 	public function processNode(Node $node, Scope $scope): array
 	{
+		if (!$this->phpVersion->supportsDeprecatedTraits()) {
+			if (count($node->getTraitReflection()->getNativeReflection()->getAttributes('Deprecated')) > 0) {
+				return [
+					RuleErrorBuilder::message('Attribute class Deprecated can be used with traits only on PHP 8.5 and later.')
+						->identifier('trait.deprecatedAttribute')
+						->nonIgnorable()
+						->build(),
+				];
+			}
+		}
+
 		$originalNode = $node->getOriginalNode();
 		$errors = $this->attributesCheck->check(
 			$scope,
@@ -42,15 +53,6 @@ public function processNode(Node $node, Scope $scope): array
 			'class',
 		);
 
-		if (!$this->phpVersion->supportsDeprecatedTraits()) {
-			if (count($node->getTraitReflection()->getNativeReflection()->getAttributes('Deprecated')) > 0) {
-				$errors[] = RuleErrorBuilder::message('Attribute class Deprecated can be used with traits only on PHP 8.5 and later.')
-					->identifier('trait.deprecatedAttribute')
-					->nonIgnorable()
-					->build();
-			}
-		}
-
 		if (count($node->getTraitReflection()->getNativeReflection()->getAttributes('AllowDynamicProperties')) > 0) {
 			$errors[] = RuleErrorBuilder::message('Attribute class AllowDynamicProperties cannot be used with trait.')
 				->identifier('trait.allowDynamicProperties')

tests/PHPStan/Reflection/ClassReflectionTest.php

@@ -7,7 +7,6 @@
 use Attributes\IsAttribute2;
 use Attributes\IsAttribute3;
 use Attributes\IsNotAttribute;
-use DeprecatedAttributeOnTrait\DeprTrait;
 use GenericInheritance\C;
 use HasTraitUse\Bar;
 use HasTraitUse\Baz;
@@ -321,8 +320,8 @@ public function testIs(): void
 
 	public static function dataDeprecatedAttribute(): iterable
 	{
-		yield [\DeprecatedAttrOnClass\Foo::class, false];
-		yield [DeprTrait::class, true]; // @phpstan-ignore classConstant.deprecatedTrait
+		yield ['DeprecatedAttrOnClass\Foo', false];
+		yield ['DeprecatedAttributeOnTrait\DeprTrait', true];
 	}
 
 	#[DataProvider('dataDeprecatedAttribute')]

tests/PHPStan/Rules/Classes/ClassAttributesRuleTest.php

@@ -2,6 +2,7 @@
 
 namespace PHPStan\Rules\Classes;
 
+use PHPStan\Php\PhpVersion;
 use PHPStan\Rules\AttributesCheck;
 use PHPStan\Rules\ClassCaseSensitivityCheck;
 use PHPStan\Rules\ClassForbiddenNameCheck;
@@ -14,6 +15,7 @@
 use PHPStan\Rules\RuleLevelHelper;
 use PHPStan\Testing\RuleTestCase;
 use PHPUnit\Framework\Attributes\RequiresPhp;
+use const PHP_VERSION_ID;
 
 /**
  * @extends RuleTestCase<ClassAttributesRule>
@@ -49,6 +51,7 @@ protected function getRule(): Rule
 				),
 				true,
 			),
+			new PhpVersion(PHP_VERSION_ID),
 		);
 	}