Add VersionCompareFunctionDynamicThrowTypeExtension

Author: VincentLanglet

src/Type/Php/VersionCompareFunctionDynamicReturnTypeExtension.php

@@ -29,7 +29,7 @@
 final class VersionCompareFunctionDynamicReturnTypeExtension implements DynamicFunctionReturnTypeExtension
 {
 
-	private const VALID_OPERATORS = [
+	public const VALID_OPERATORS = [
 		'<',
 		'lt',
 		'<=',

src/Type/Php/VersionCompareFunctionDynamicThrowTypeExtension.php

@@ -0,0 +1,60 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Type\Php;
+
+use PhpParser\Node\Expr\FuncCall;
+use PHPStan\Analyser\Scope;
+use PHPStan\DependencyInjection\AutowiredService;
+use PHPStan\Php\PhpVersion;
+use PHPStan\Reflection\FunctionReflection;
+use PHPStan\Type\DynamicFunctionThrowTypeExtension;
+use PHPStan\Type\Type;
+use function count;
+use function in_array;
+
+#[AutowiredService]
+final class VersionCompareFunctionDynamicThrowTypeExtension implements DynamicFunctionThrowTypeExtension
+{
+
+	public function __construct(
+		private PhpVersion $phpVersion,
+	)
+	{
+	}
+
+	public function isFunctionSupported(FunctionReflection $functionReflection): bool
+	{
+		return $functionReflection->getName() === 'version_compare';
+	}
+
+	public function getThrowTypeFromFunctionCall(
+		FunctionReflection $functionReflection,
+		FuncCall $funcCall,
+		Scope $scope,
+	): ?Type
+	{
+		if (!$this->phpVersion->throwsValueErrorForInternalFunctions()) {
+			return null;
+		}
+
+		$args = $funcCall->getArgs();
+		if (!isset($args[2])) {
+			return null;
+		}
+
+		$operatorStrings = $scope->getType($args[2]->value)->getConstantStrings();
+		if (count($operatorStrings) === 0) {
+			return $functionReflection->getThrowType();
+		}
+
+		foreach ($operatorStrings as $operatorString) {
+			$operatorValue = $operatorString->getValue();
+			if (!in_array($operatorValue, VersionCompareFunctionDynamicReturnTypeExtension::VALID_OPERATORS, true)) {
+				return $functionReflection->getThrowType();
+			}
+		}
+
+		return null;
+	}
+
+}

tests/PHPStan/Rules/Exceptions/ThrowsVoidFunctionWithExplicitThrowPointRuleTest.php

@@ -97,4 +97,11 @@ public function testRule(bool $missingCheckedExceptionInThrows, array $checkedEx
 		$this->analyse([__DIR__ . '/data/throws-void-function.php'], $errors);
 	}
 
+	public function testBug13515(): void
+	{
+		$this->missingCheckedExceptionInThrows = false;
+		$this->checkedExceptionClasses = [];
+		$this->analyse([__DIR__ . '/data/bug-13515.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Exceptions/data/bug-13515.php

@@ -0,0 +1,18 @@
+<?php
+
+namespace Bug13515;
+
+/** @throws void */
+function fromArray(string $name, string $versionWithoutMicro) : void
+{
+	if ($name === 'Mac OS X'
+		&& \version_compare(
+			$versionWithoutMicro,
+			'10.12',
+			'>='
+		)
+	) {
+		$name          = 'macOS';
+		$marketingName = 'macOS';
+	}
+}