Skip to content

socket: properly expose TCP keepalive constants #20376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2025
Merged

socket: properly expose TCP keepalive constants #20376

merged 1 commit into from
Nov 3, 2025
+61 −1

Conversation

@bukka
Copy link
Member

@bukka bukka commented Nov 3, 2025 •
edited
Loading

This doesn't seems to be correctly exposed for MacOS where TCP_KEEPALIVE, TCP_KEEPINTVL and TCP_KEEPCNT are available

@bukka bukka merged commit 2d105af into php:master Nov 3, 2025
10 checks passed
@Girgias
Copy link
Member

Girgias commented Nov 4, 2025 •
edited
Loading

Please add these constants to UPGRADING. Ignore, I didn't realize this is just adding some #ifdefs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devnexen devnexen devnexen approved these changes

@kocsismate kocsismate Awaiting requested review from kocsismate kocsismate is a code owner

Assignees

No one assigned

Labels

Extension: sockets STF: Streams

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bukka @Girgias @devnexen