Use ZEND_BYTES_SWAP32() for php_pack_reverse_int32()

nielsdos · nielsdos · commit 3b1918b2a8c1 · 2025-06-11T21:01:35.000+02:00
diff --git a/ext/standard/pack.c b/ext/standard/pack.c
@@ -96,10 +96,7 @@ ZEND_ATTRIBUTE_CONST static inline uint16_t php_pack_reverse_int16(uint16_t arg)
 /* {{{ php_pack_reverse_int32 */
 ZEND_ATTRIBUTE_CONST static inline uint32_t php_pack_reverse_int32(uint32_t arg)
 {
-	uint32_t result;
-	result = ((arg & 0xFF) << 24) | ((arg & 0xFF00) << 8) | ((arg >> 8) & 0xFF00) | ((arg >> 24) & 0xFF);
-
-	return result;
+	return ZEND_BYTES_SWAP32(arg);
 }
 /* }}} */
 

Original file line number	Diff line number	Diff line change
`@@ -96,10 +96,7 @@ ZEND_ATTRIBUTE_CONST static inline uint16_t php_pack_reverse_int16(uint16_t arg)`
`96`	`96`	`/* {{{ php_pack_reverse_int32 */`
`97`	`97`	`ZEND_ATTRIBUTE_CONST static inline uint32_t php_pack_reverse_int32(uint32_t arg)`
`98`	`98`	`{`
`99`		`- uint32_t result;`
`100`		`- result = ((arg & 0xFF) << 24) \| ((arg & 0xFF00) << 8) \| ((arg >> 8) & 0xFF00) \| ((arg >> 24) & 0xFF);`
`101`		`-`
`102`		`- return result;`
	`99`	`+ return ZEND_BYTES_SWAP32(arg);`
`103`	`100`	`}`
`104`	`101`	`/* }}} */`
`105`	`102`