-
-
Notifications
You must be signed in to change notification settings - Fork 39
Add more data to the dev seeds #481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
MareStare
wants to merge
61
commits into
philomena-dev:master
Choose a base branch
from
MareStare:feat/import-seeds-from-redesign-branch
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add more data to the dev seeds #481
MareStare
wants to merge
61
commits into
philomena-dev:master
from
MareStare:feat/import-seeds-from-redesign-branch
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c207961
to
1bebe12
Compare
1 task
1bebe12
to
4b9b9cc
Compare
818aede
to
8ee8d96
Compare
I have a few suggestions, since I'm pretty much the original author of a lot of this PRs stuff:
|
3aedd22
to
da4e19a
Compare
This was referenced Apr 6, 2025
…ase` with a function-level match
I want to share the same context, but make a separate test for the edge-case scenario.
Looks like package was renamed in NPM registry to `@vitest/eslint-plugin`. This package is from same exact repository.
Resolves issue with conflicting dependencies when trying to install `@vitest/eslint-plugin`: npm error Could not resolve dependency: npm error dev @vitest/eslint-plugin@"*" from the root project npm error npm error Conflicting peer dependency: @typescript-eslint/[email protected] npm error node_modules/@typescript-eslint/utils npm error peer @typescript-eslint/utils@"^8.24.0" from @vitest/[email protected] npm error node_modules/@vitest/eslint-plugin npm error dev @vitest/eslint-plugin@"*" from the root project
As suggested by @MareStare
This reverts commit e68d7c3.
…st, but maybe a couple of seconds)
…se upload concurrency and better logs
4582f70
to
2b12042
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before you begin
This PR cherry-picks two commits from the
redesign
branch (2d5da61 and 16978b3).Note that with all this new seed data the initial startup now takes several minutes (haven't measured exactly), but I think it's worth it.
Improved logging
Added command logging with color highlight to the dev scripts, so now the logs look like this:
I also noticed this warning in the seeding logs:
Plus this warning:
philomena/lib/philomena_media/objects.ex
Line 200 in 78550a6
And, there was also the following error:
I'll try to take a closer look at those, but even with these issues I could still open the site and see the new data.