Skip to content

Commit 81f8cc7

Browse files
committed
pmie - restart the pmie service if the configuration tasks made any changes.
1 parent a64affb commit 81f8cc7

File tree

1 file changed

+25
-2
lines changed

1 file changed

+25
-2
lines changed

roles/pcp/tasks/pmie.yml

Lines changed: 25 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
group: root
1010
mode: 0755
1111
loop: "{{ __pcp_pmieconf_groups|default([]) }}"
12+
register: __pcp_register_changed_group_dir
1213

1314
- name: Ensure extra performance rule group link directories exist
1415
file:
@@ -18,6 +19,7 @@
1819
group: root
1920
mode: 0755
2021
loop: "{{ __pcp_pmieconf_groups|default([]) }}"
22+
register: __pcp_register_changed_group_link_dir
2123

2224
- name: Ensure extra performance rules are installed for targeted hosts
2325
copy:
@@ -27,6 +29,7 @@
2729
group: root
2830
mode: '0644'
2931
loop: "{{ __pcp_pmieconf_rules|default([]) }}"
32+
register: __pcp_register_changed_rules_for_hosts
3033

3134
- name: Ensure extra rules symlinks have been created for targeted hosts
3235
file:
@@ -35,14 +38,15 @@
3538
state: link
3639
force: yes
3740
loop: "{{ __pcp_pmieconf_rules|default([]) }}"
41+
register: __pcp_register_changed_symlinks_for_hosts
3842

3943
- name: Enable performance metric inference for targeted hosts (with control.d)
4044
template:
4145
src: pmie.controld.j2
4246
dest: "{{ __pcp_pmie_control_d_path }}/{{ item }}"
4347
mode: 0644
4448
loop: "{{ pcp_target_hosts|default([]) }}"
45-
notify: restart pmie
49+
register: __pcp_register_changed_target_hosts_controld
4650
when:
4751
- not pcp_single_control|d(false)|bool
4852
- pcp_target_hosts|d([])
@@ -52,13 +56,32 @@
5256
src: pmie.control.j2
5357
dest: "{{ __pcp_pmie_control_path }}"
5458
mode: 0644
55-
notify: restart pmie
59+
register: __pcp_register_changed_target_hosts_single
5660
when:
5761
- pcp_single_control|d(true)|bool
5862
- pcp_target_hosts|d([])
5963

64+
- name: Set variable to do pmie restart if needed
65+
set_fact:
66+
__pcp_restart_pmie: "{{
67+
__pcp_register_changed_group_dir is changed or
68+
__pcp_register_changed_group_link_dir is changed or
69+
__pcp_register_changed_rules_for_hosts is changed or
70+
__pcp_register_changed_symlinks_for_hosts is changed or
71+
__pcp_register_changed_target_hosts_controld is changed or
72+
__pcp_register_changed_target_hosts_single is changed
73+
}}"
74+
6075
- name: Ensure performance metric inference is running and enabled on boot
6176
service:
6277
name: pmie
6378
state: started
6479
enabled: yes
80+
when: not __pcp_restart_pmie | bool
81+
82+
- name: Ensure performance metric inference is restarted and enabled on boot
83+
service:
84+
name: pmie
85+
state: restarted
86+
enabled: yes
87+
when: __pcp_restart_pmie | bool

0 commit comments

Comments
 (0)