PS-10287 [8.0]: Add automatic table definition recovery after crash on ALTER #5761
+263
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
storage/rocksdb/ha_rocksdb.cc
Outdated
|
|
||
| try { | ||
| new_key_descr = new std::shared_ptr<Rdb_key_def>[new_n_keys]; | ||
| new_tdef = new Rdb_tbl_def(tbl_name); |
Collaborator
There was a problem hiding this comment.
If this allocation throws, we will have new_key_descr leaked.
May be use std::unique_ptr<Rdb_tbl_def> new_tdef and std::unique_ptr<Rdb_key_def[]> new_key_descr ?
Collaborator
Author
There was a problem hiding this comment.
This is a good idea, implemented.
inikep
changed the title
inikep
changed the title
…n ALTER Add mechanisms to detect and recover corrupted table definitions (`Rdb_tbl_def`) in MyRocks after incomplete `ALTER TABLE ... ADD INDEX` operations. - Log detailed mismatch information between `m_key_count` and actual table keys, including the likely ALTER operation that caused it. - Introduce `delete_table_def()` to remove table definitions without touching table data. - Implement `rebuild_table_def_from_table()` to reconstruct corrupted `Rdb_tbl_def` by removing partially added indexes, preserving existing data. - Reduce verbosity of informational key logging from `ERROR_LEVEL` to `INFORMATION_LEVEL`. - Add optional automatic table validation/reconstruction controlled by `rocksdb_validate_tables` server variable. - Add the `rocksdb.recovery_after_alter_crash` MTR test, which simulates a server crash during an `ALTER TABLE … ADD INDEX` operation, detects a corrupted table definition, and verifies automatic recovery.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add mechanisms to detect and recover corrupted table definitions (
Rdb_tbl_def) in MyRocks after incompleteALTER TABLE ... ADD INDEXoperations.m_key_countand actual table keys, including the likely ALTER operation that caused it.delete_table_def()to remove table definitions without touching table data.rebuild_table_def_from_table()to reconstruct corruptedRdb_tbl_defby removing partially added indexes, preserving existing data.ERROR_LEVELtoINFORMATION_LEVEL.rocksdb_validate_tablesserver variable.