Skip to content

Newly posted commentary does not appear on the 2023-06 event feed #1119

@johnbrvc

Description

@johnbrvc

Describe the issue:
If the "add commentary" extension to the 2023-06 CLICS API implementation for the commentary endpoint is used, a notification is not generated on the 2023-06 event feed.

To Reproduce:

  1. Start a contest
  2. Start an event feed thick client feeding the 2023-06 API
  3. Start a remote event feed consumer, eg. curl -k https://admin:admin@localhost:50443/contests/XXXX/event-feed
  4. Post a new comment using the POST facility on the commentary endpoint (note that this is an extension to 2023-06, but will officially be part of the 2025-09 CLICS API specification.
  5. Notice that no notification event is generated on the event feed consumer

Expected behavior:
You would expect to see a commentary notification on the event feed.

Actual behavior:
No commentary notification appears on the event feed. Note, however, that the commentary endpoint to GET commentary does work.

Environment:
All.

Log Info:

Screenshots:

Additional context:
Code was omitted from the original PR #1085 that arranges for the notification on commentary to be sent out. This was an oversight and a new PR (in response to this issue) will be created to add that code. The reason it was accidentally left of is because it was in a separate branch. The reason for the separate branch was that the code was meant to be temporary until such a time that commentary is officially added to the contest model. Right now, commentary is kind of "off on its own" and not stored in the PC2 database. Rather, it is stored in a flat file like the event feed itself. Of course, this will change when a model for it is created.

Metadata

Metadata

Assignees

Labels

CLICS CCS UpdateChanges to update to the CLICS specificationNEXT ContestConsider fixing for next contetPrimary CCSRequired for PC2 to act as primary CCSUsability IssueThis is an enhancement for which there is currently no usable workaroundbugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions