-
Notifications
You must be signed in to change notification settings - Fork 26
Description
Describe the issue:
If the "add commentary" extension to the 2023-06 CLICS API implementation for the commentary endpoint is used, a notification is not generated on the 2023-06 event feed.
To Reproduce:
- Start a contest
- Start an event feed thick client feeding the 2023-06 API
- Start a remote event feed consumer, eg. curl -k https://admin:admin@localhost:50443/contests/XXXX/event-feed
- Post a new comment using the POST facility on the commentary endpoint (note that this is an extension to 2023-06, but will officially be part of the 2025-09 CLICS API specification.
- Notice that no notification event is generated on the event feed consumer
Expected behavior:
You would expect to see a commentary notification on the event feed.
Actual behavior:
No commentary notification appears on the event feed. Note, however, that the commentary endpoint to GET commentary does work.
Environment:
All.
Log Info:
Screenshots:
Additional context:
Code was omitted from the original PR #1085 that arranges for the notification on commentary to be sent out. This was an oversight and a new PR (in response to this issue) will be created to add that code. The reason it was accidentally left of is because it was in a separate branch. The reason for the separate branch was that the code was meant to be temporary until such a time that commentary is officially added to the contest model. Right now, commentary is kind of "off on its own" and not stored in the PC2 database. Rather, it is stored in a flat file like the event feed itself. Of course, this will change when a model for it is created.