Skip to content

Commit e54e69e

Browse files
alexanderzaiets-payserapelanis
authored andcommitted
review concern fix
1 parent b6d6bf7 commit e54e69e

File tree

1 file changed

+19
-19
lines changed

1 file changed

+19
-19
lines changed

README.md

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1260,7 +1260,7 @@ Example of parent class, with which calling constructor later would fail:
12601260
/**
12611261
* @var int[] $params
12621262
*/
1263-
protected array $params;
1263+
private array $params;
12641264
public function __construct(int $arg1)
12651265
{
12661266
$this->params = [$arg1];
@@ -1613,7 +1613,7 @@ Instead of:
16131613
<?php
16141614
class BadExample
16151615
{
1616-
protected string $name;
1616+
private string $name;
16171617
public function setManagerName(string $name): self
16181618
{
16191619
$this->name = $name;
@@ -1878,7 +1878,7 @@ class Manager
18781878
/**
18791879
* @var ProviderInterface[]
18801880
*/
1881-
protected $providers = [];
1881+
private $providers = [];
18821882

18831883
public function addProvider(ProviderInterface $provider, string $providerKey): self
18841884
{
@@ -2566,8 +2566,8 @@ use Doctrine\ORM\EntityManagerInterface;
25662566
25672567
class FooProcessor
25682568
{
2569-
protected EntityManagerInterface $entityManager;
2570-
protected RemoteServiceClient $remoteServiceClient;
2569+
private EntityManagerInterface $entityManager;
2570+
private RemoteServiceClient $remoteServiceClient;
25712571
25722572
public function __construct(EntityManagerInterface $entityManager, RemoteServiceClient $remoteServiceClient)
25732573
{
@@ -3131,22 +3131,22 @@ declare(strict_types=1);
31313131
31323132
class MainEntity
31333133
{
3134-
protected int $id;
3135-
protected string $type;
3134+
private int $id;
3135+
private string $type;
31363136
}
31373137
31383138
class SubEntity
31393139
{
3140-
protected int $id;
3141-
protected MainEntity $mainEntity;
3142-
protected string $subValue;
3140+
private int $id;
3141+
private MainEntity $mainEntity;
3142+
private string $subValue;
31433143
}
31443144
31453145
class AnotherSubEntity
31463146
{
3147-
protected int $id;
3148-
protected MainEntity $mainEntity;
3149-
protected string $anotherSubValue;
3147+
private int $id;
3148+
private MainEntity $mainEntity;
3149+
private string $anotherSubValue;
31503150
}
31513151
```
31523152

@@ -3159,10 +3159,10 @@ declare(strict_types=1);
31593159
31603160
class Entity
31613161
{
3162-
protected int $id;
3163-
protected string $type;
3164-
protected string $subValue;
3165-
protected string $anotherSubValue;
3162+
private int $id;
3163+
private string $type;
3164+
private string $subValue;
3165+
private string $anotherSubValue;
31663166
}
31673167
```
31683168

@@ -3179,11 +3179,11 @@ class Entity
31793179
}
31803180
class SubEntity extends Entity
31813181
{
3182-
protected string $subValue;
3182+
private string $subValue;
31833183
}
31843184
class AnotherSubEntity extends Entity
31853185
{
3186-
protected string $anotherSubValue;
3186+
private string $anotherSubValue;
31873187
}
31883188
```
31893189

0 commit comments

Comments
 (0)