Skip to content

Commit 6348748

Browse files
Copilotpawcoding
andcommitted
fix: use proper types for test options instead of any
Co-authored-by: pawcoding <[email protected]>
1 parent 3d86a77 commit 6348748

File tree

6 files changed

+14
-12
lines changed

6 files changed

+14
-12
lines changed

test/_mocks/delete-collection.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import { assert } from "vitest";
2-
import type { PocketBaseLoaderOptions } from "../../src/types/pocketbase-loader-options.type";
2+
import type { PocketBaseLoaderBaseOptions } from "../../src/types/pocketbase-loader-options.type";
33

44
export async function deleteCollection(
5-
options: PocketBaseLoaderOptions,
5+
options: PocketBaseLoaderBaseOptions,
66
superuserToken: string
77
): Promise<void> {
88
const deleteRequest = await fetch(

test/_mocks/delete-entry.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
import { assert } from "vitest";
2-
import type { PocketBaseLoaderOptions } from "../../src/types/pocketbase-loader-options.type";
2+
import type { PocketBaseLoaderBaseOptions } from "../../src/types/pocketbase-loader-options.type";
33
import { sendBatchRequest } from "./batch-requests";
44

55
export async function deleteEntries(
66
entryIds: Array<string>,
7-
options: PocketBaseLoaderOptions,
7+
options: PocketBaseLoaderBaseOptions,
88
superuserToken: string
99
): Promise<void> {
1010
const requests = entryIds.map((entryId) => ({
@@ -26,7 +26,7 @@ export async function deleteEntries(
2626

2727
export async function deleteEntry(
2828
entryId: string,
29-
options: PocketBaseLoaderOptions,
29+
options: PocketBaseLoaderBaseOptions,
3030
superuserToken: string
3131
): Promise<void> {
3232
const deleteRequest = await fetch(

test/_mocks/insert-collection.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
import { assert } from "console";
2-
import type { PocketBaseLoaderOptions } from "../../src/types/pocketbase-loader-options.type";
2+
import type { PocketBaseLoaderBaseOptions } from "../../src/types/pocketbase-loader-options.type";
33
import type { PocketBaseSchemaEntry } from "../../src/types/pocketbase-schema.type";
44

55
export async function insertCollection(
66
fields: Array<PocketBaseSchemaEntry>,
7-
options: PocketBaseLoaderOptions,
7+
options: PocketBaseLoaderBaseOptions,
88
superuserToken: string
99
): Promise<void> {
1010
const insertRequest = await fetch(new URL(`api/collections`, options.url), {

test/_mocks/insert-entry.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
import { assert } from "vitest";
22
import type { PocketBaseEntry } from "../../src/types/pocketbase-entry.type";
3-
import type { PocketBaseLoaderOptions } from "../../src/types/pocketbase-loader-options.type";
3+
import type { PocketBaseLoaderBaseOptions } from "../../src/types/pocketbase-loader-options.type";
44
import { sendBatchRequest } from "./batch-requests";
55

66
export async function insertEntries(
77
data: Array<Record<string, unknown>>,
8-
options: PocketBaseLoaderOptions,
8+
options: PocketBaseLoaderBaseOptions,
99
superuserToken: string
1010
): Promise<Array<PocketBaseEntry>> {
1111
const requests = data.map((entry) => ({
@@ -34,7 +34,7 @@ export async function insertEntries(
3434

3535
export async function insertEntry(
3636
data: Record<string, unknown>,
37-
options: PocketBaseLoaderOptions,
37+
options: PocketBaseLoaderBaseOptions,
3838
superuserToken: string
3939
): Promise<PocketBaseEntry> {
4040
const insertRequest = await fetch(

test/loader/fetch-collection.e2e-spec.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import { beforeEach, describe, expect, inject, test, vi } from "vitest";
77
import { fetchCollection } from "../../src/loader/fetch-collection";
88
import { PocketBaseAuthenticationError } from "../../src/types/errors";
99
import type { PocketBaseEntry } from "../../src/types/pocketbase-entry.type";
10+
import type { ExperimentalPocketBaseLiveLoaderOptions } from "../../src/types/pocketbase-loader-options.type";
1011
import { createLoaderOptions } from "../_mocks/create-loader-options";
1112
import { deleteCollection } from "../_mocks/delete-collection";
1213
import { insertCollection } from "../_mocks/insert-collection";
@@ -497,7 +498,7 @@ describe("fetchCollection", () => {
497498

498499
describe("expand parameter", () => {
499500
test("should include expand parameter in request when experimental.expand option is provided", async () => {
500-
const testOptions: any = {
501+
const testOptions: ExperimentalPocketBaseLiveLoaderOptions = {
501502
...options,
502503
collectionName: randomUUID().replaceAll("-", ""),
503504
experimental: {

test/loader/fetch-entry.e2e-spec.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import { randomUUID } from "crypto";
33
import { describe, expect, inject, test } from "vitest";
44
import { fetchEntry } from "../../src/loader/fetch-entry";
55
import { PocketBaseAuthenticationError } from "../../src/types/errors";
6+
import type { ExperimentalPocketBaseLiveLoaderOptions } from "../../src/types/pocketbase-loader-options.type";
67
import { createLoaderOptions } from "../_mocks/create-loader-options";
78
import { deleteCollection } from "../_mocks/delete-collection";
89
import { insertCollection } from "../_mocks/insert-collection";
@@ -198,7 +199,7 @@ describe("fetchEntry", () => {
198199

199200
describe("expand parameter", () => {
200201
test("should include expand parameter in request when experimental.expand option is provided", async () => {
201-
const testOptions: any = {
202+
const testOptions: ExperimentalPocketBaseLiveLoaderOptions = {
202203
...options,
203204
collectionName: randomUUID().replaceAll("-", ""),
204205
experimental: {

0 commit comments

Comments
 (0)