Skip to content

Commit 6ee5eae

Browse files
author
patricktr
committed
Bug fix that prevented sorting on a draggable column
Bug fix for `enableColumnWideDrag` prop by adding css `display: inline-flex` when set to {false}
1 parent d53fb6c commit 6ee5eae

File tree

5 files changed

+14
-4
lines changed

5 files changed

+14
-4
lines changed

CHANGELOG.md

+5
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
# 1.2.2 (2020-1-17)
2+
3+
Bug fix that prevented sorting on a draggable column
4+
Bug fix for `enableColumnWideDrag` prop by adding css `display: inline-flex` when set to {false}
5+
16
# 1.2.1 (2019-10-9)
27

38
Bug fix for correctly converting a HTML Collection to Javascript array (was broken for some browsers)

example/src/stories/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ stories.add('Reorder Columns', () => {
2727
draggableColumns={{
2828
mode: DragMode.REORDER,
2929
draggable: text('draggable', ['vin', 'year', 'brand', 'color']),
30-
enableColumnWideDrag: boolean('enableColumnWideDrag', true),
30+
enableColumnWideDrag: boolean('enableColumnWideDrag', false),
3131
disableTableScroll: boolean('disableTableScroll', true),
3232
useDragImage: boolean('useDragImage', true),
3333
onDraggedColumnChange: cols => console.log('new order', cols),

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "react-table-hoc-draggable-columns",
3-
"version": "1.2.1",
3+
"version": "1.2.2",
44
"description": "ReactTable HOC for draggable columns",
55
"author": "patricktran",
66
"license": "MIT",

src/index.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -452,11 +452,11 @@ export default Component => {
452452
...col,
453453
Header:
454454
typeof col.Header === 'function' ? (
455-
<div onClick={this.stopPropagation} className={headerClassName}>
455+
<div className={headerClassName}>
456456
{col.Header()}
457457
</div>
458458
) : (
459-
<div onClick={this.stopPropagation} className={headerClassName}>
459+
<div className={headerClassName}>
460460
{col.Header}
461461
</div>
462462
)

src/styles.scss

+5
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,11 @@
1616
padding: 2px 8px;
1717
}
1818

19+
//css for when `enableColumnWideDrag` prop is set to {false}
20+
div[draggable='true'].draggable-header.enable-drag {
21+
display: inline-flex;
22+
}
23+
1924
.draggable-header.enable-drag:hover {
2025
cursor: move;
2126
}

0 commit comments

Comments
 (0)