Handled bool column

[parmesant]

Boolean column conditions were failing. Added type handling for that.

Fixes #XXXX.

Description

---

This PR has:

• been tested to ensure log ingestion and log query works.
• added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
• added documentation for new or modified features or behaviors.

Summary by CodeRabbit

• New Features

  • Added support for boolean values in alert filters, allowing users to input and filter by true/false values in addition to numbers and strings.

• Bug Fixes

  • Improved parsing of filter values to correctly recognize and handle boolean inputs.

[coderabbitai]

Walkthrough

The changes extend the existing NumberOrString enum to a new ValueType enum by adding a Boolean variant. All related code now uses ValueType, with parsing and formatting logic updated to recognize and handle boolean values in addition to numbers and strings.

Changes

File(s)	Change Summary
src/alerts/alerts_utils.rs	Replaced NumberOrString with ValueType, added Boolean variant, updated parsing and formatting logic for booleans, and revised trait implementations accordingly.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant AlertsUtils

    User->>AlertsUtils: Provide value as string
    AlertsUtils->>AlertsUtils: ValueType::from_string(input)
    alt Input parses as number
        AlertsUtils->>User: ValueType::Number
    else Input parses as boolean
        AlertsUtils->>User: ValueType::Boolean
    else
        AlertsUtils->>User: ValueType::String
    end

Loading

Estimated code review effort

2 (30–90 minutes)

Possibly related PRs

• fix: handle proper SQL variable type for operators #1379: Modifies related functions for value handling, focusing on escaping string values and separating raw escaped strings from parsed types, which overlaps with parsing and formatting logic.

Poem

A hop and a skip, a Boolean leap,
Our enum now counts more than numbers and sheep!
From strings to true/false, the types are in bloom,
With ValueType's magic, there's plenty more room.
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d3bb3ae and 2cb25fc.

📒 Files selected for processing (1)

• src/alerts/alerts_utils.rs (3 hunks)

🧰 Additional context used

🧠 Learnings (1)

📓 Common learnings

Learnt from: de-sh
PR: parseablehq/parseable#0
File: :0-0
Timestamp: 2025-03-20T15:50:45.435Z
Learning: Pay close attention to code comments for typos and semantic clarity during reviews for the Parseable project.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)

• GitHub Check: coverage
• GitHub Check: Build Default x86_64-unknown-linux-gnu
• GitHub Check: Build Default x86_64-pc-windows-msvc
• GitHub Check: Quest Smoke and Load Tests for Standalone deployments
• GitHub Check: Build Default x86_64-apple-darwin
• GitHub Check: Quest Smoke and Load Tests for Distributed deployments
• GitHub Check: Build Kafka aarch64-apple-darwin
• GitHub Check: Build Kafka x86_64-unknown-linux-gnu
• GitHub Check: Build Default aarch64-apple-darwin
• GitHub Check: Build Default aarch64-unknown-linux-gnu

🔇 Additional comments (6)

src/alerts/alerts_utils.rs (6)

427-433: LGTM! Boolean formatting implemented correctly.

The updated logic properly handles boolean values by formatting them without quotes (like numbers), while maintaining proper quoting for strings. This correctly addresses the boolean column condition failures mentioned in the PR.

---

465-465: LGTM! Consistent with enum renaming.

The function call correctly uses the new ValueType::from_string method, maintaining functionality while being consistent with the enum renaming.

---

529-533: LGTM! Well-designed enum extension.

The renaming from NumberOrString to ValueType is more descriptive and the addition of the Boolean(bool) variant properly addresses boolean column handling. The design maintains existing functionality while extending support for boolean values.

---

535-543: LGTM! Complete and correct trait implementation.

The Literal trait implementation properly handles all three variants with correct dereferencing for primitive types (Number, Boolean) and cloning for the String variant. The implementation correctly uses datafusion's lit function for all cases.

---

544-554: LGTM! Appropriate parsing order for alert context.

The boolean parsing logic is correctly implemented with a sensible precedence: number → boolean → string. This ensures that "true"/"false" values are properly recognized as booleans in alert conditions, which aligns with the PR's goal of handling boolean columns.

---

556-564: LGTM! Consistent Display implementation.

The Display trait implementation is consistent across all variants, properly formatting boolean values as "true"/"false" strings, which is appropriate for logging and debugging purposes.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.